Fix freeze with rustfmt on 2019.2 & some rustfmt cleanup #4151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Particularly, `cargo install --list` and `rustup component list`. Usually they works less then 100ms. By 1000ms timeout we guarantee that UI will not froze if something goes wrong.
This progress window is mostly useless with run-rustfmt-on-save b/c during document save we invoking rustfmt in the write action where progress window can't be shown.
vlad20012
force-pushed
the
issue-4142-freeze
branch
from
fdc795d
to
58aafdf
Compare
bors bot
added a commit
that referenced
this pull request
Jul 17, 2019
4078: INSP: support `pub extern crate` reexports r=vlad20012 a=Undin Fixes #3396 4136: T: Extract performance and real project tests to rustPerformanceTests r=Undin a=ortem 4148: ANN: Fix E0618: Type implementing a Fn trait is a function too r=mchernyavsky a=mibac138 Fixes #4143 4151: Fix freeze with rustfmt on 2019.2 & some rustfmt cleanup r=mchernyavsky a=vlad20012 Really #4142 is a [platform bug](https://youtrack.jetbrains.com/issue/IDEA-218430) and I just fixed it in the platform, but I don't know when it will be upstreamed. This PR is a hotfix. Fixes #4142 Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru> Co-authored-by: ortem <ortem00@gmail.com> Co-authored-by: mibac138 <5672750+mibac138@users.noreply.github.com> Co-authored-by: vlad20012 <beskvlad@gmail.com>
Canceled (will resume) |
bors bot
added a commit
that referenced
this pull request
Jul 17, 2019
4078: INSP: support `pub extern crate` reexports r=vlad20012 a=Undin Fixes #3396 4148: ANN: Fix E0618: Type implementing a Fn trait is a function too r=mchernyavsky a=mibac138 Fixes #4143 4151: Fix freeze with rustfmt on 2019.2 & some rustfmt cleanup r=mchernyavsky a=vlad20012 Really #4142 is a [platform bug](https://youtrack.jetbrains.com/issue/IDEA-218430) and I just fixed it in the platform, but I don't know when it will be upstreamed. This PR is a hotfix. Fixes #4142 Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru> Co-authored-by: mibac138 <5672750+mibac138@users.noreply.github.com> Co-authored-by: vlad20012 <beskvlad@gmail.com>
Build failed (retrying...) |
bors bot
added a commit
that referenced
this pull request
Jul 17, 2019
4148: ANN: Fix E0618: Type implementing a Fn trait is a function too r=mchernyavsky a=mibac138 Fixes #4143 4151: Fix freeze with rustfmt on 2019.2 & some rustfmt cleanup r=mchernyavsky a=vlad20012 Really #4142 is a [platform bug](https://youtrack.jetbrains.com/issue/IDEA-218430) and I just fixed it in the platform, but I don't know when it will be upstreamed. This PR is a hotfix. Fixes #4142 Co-authored-by: mibac138 <5672750+mibac138@users.noreply.github.com> Co-authored-by: vlad20012 <beskvlad@gmail.com>
Build failed (retrying...) |
bors bot
added a commit
that referenced
this pull request
Jul 17, 2019
4151: Fix freeze with rustfmt on 2019.2 & some rustfmt cleanup r=mchernyavsky a=vlad20012 Really #4142 is a [platform bug](https://youtrack.jetbrains.com/issue/IDEA-218430) and I just fixed it in the platform, but I don't know when it will be upstreamed. This PR is a hotfix. Fixes #4142 Co-authored-by: vlad20012 <beskvlad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really #4142 is a platform bug and I just fixed it in the platform, but I don't know when it will be upstreamed. This PR is a hotfix.
Fixes #4142