Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment processing in RsStatementUpDownMover #4160

Merged
merged 1 commit into from Jul 20, 2019
Merged

Fix comment processing in RsStatementUpDownMover #4160

merged 1 commit into from Jul 20, 2019

Conversation

artemmukhin
Copy link
Member

Fixes #3548

@artemmukhin artemmukhin added the fix Pull requests that fix some bug(s) label Jul 18, 2019
@mchernyavsky mchernyavsky added this to the v102 milestone Jul 18, 2019
mchernyavsky
mchernyavsky approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jul 20, 2019
@bors @artemmukhin
Merge #4160
00a28c0 
4160: Fix comment processing in RsStatementUpDownMover r=mchernyavsky a=ortem

Fixes #3548

Co-authored-by: ortem <ortem00@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 20, 2019

Build succeeded

@bors bors bot merged commit 805d70e into master Jul 20, 2019
@Undin Undin deleted the up-down-mover-comment-fix branch July 22, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchernyavsky mchernyavsky mchernyavsky approved these changes

Assignees

@mchernyavsky mchernyavsky

Labels
fix Pull requests that fix some bug(s)
Projects
None yet
Milestone
v102
Development

Successfully merging this pull request may close these issues.

Up/down mover produces an unexpected result if moved statement starts/ends with a comment
2 participants
@artemmukhin @mchernyavsky