Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INSP: lift inspection for return expression #4172

Merged
merged 3 commits into from Dec 21, 2019
Merged

INSP: lift inspection for return expression #4172

merged 3 commits into from Dec 21, 2019

Conversation

Undin
Copy link
Member

@Undin Undin commented Jul 22, 2019 •
edited

2019-07-22 14 17 23

TODO:

  • Find out expression size threshold
  • Check with real projects

@Undin Undin added the feature label Jul 22, 2019
@Undin Undin added this to In Progress in To test Aug 9, 2019
@Undin Undin marked this pull request as ready for review December 16, 2019 11:25
@Undin
T: new way to mark expected highlighted text
1d2362d 
Now it's possible to mark expected highlighted text via special Rust comment
like `/*error descr="description text"*/ highlighted text /*error**/`.
It allows avoiding error annotation in injected rust code snippets in tests
@Undin
INSP: implement lift return inspection
b1d3f4a
@Undin
T: test lift return inspection
81f7da2
@Undin Undin added this to the v113 milestone Dec 21, 2019
@Undin
Copy link
Member Author

Undin commented Dec 21, 2019

bors r=ortem

bors bot added a commit that referenced this pull request Dec 21, 2019
@bors @Undin
Merge #4172
55584cc 
4172: INSP: lift inspection for return expression r=ortem a=Undin


![2019-07-22 14 17 23](https://user-images.githubusercontent.com/2539310/61629021-7895e880-ac8c-11e9-8dab-efc36afdb384.gif)

TODO:
* [ ] Find out expression size threshold
* [x] Check with real projects

Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
@bors
Copy link
Contributor

bors bot commented Dec 21, 2019

Build succeeded

@bors bors bot merged commit 81f7da2 into master Dec 21, 2019
To test automation moved this from In Progress to Test Dec 21, 2019
@bors bors bot deleted the lift-intention branch December 21, 2019 13:50
@lancelote lancelote mentioned this pull request Dec 26, 2019
Closed
@lancelote lancelote moved this from Test to Done in To test Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemmukhin artemmukhin artemmukhin approved these changes

Assignees

@artemmukhin artemmukhin

Labels
feature
Projects
To test
  
Done
Milestone
v113
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Undin @artemmukhin