Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Substitute types in completion variants #4207

Merged
merged 2 commits into from Aug 6, 2019
Merged

Conversation

mchernyavsky
Copy link
Member

@mchernyavsky mchernyavsky commented Jul 31, 2019

image

@mchernyavsky mchernyavsky changed the title WIP: Substitute types in lookup elements WIP: Substitute types in completion variants Aug 1, 2019
@mchernyavsky mchernyavsky force-pushed the subst-ty-lookup-elements branch 2 times, most recently from 3178706 to 989536c Compare August 2, 2019 03:58
@mchernyavsky mchernyavsky changed the title WIP: Substitute types in completion variants COMP: Substitute types in completion variants Aug 2, 2019
@mchernyavsky mchernyavsky force-pushed the subst-ty-lookup-elements branch 5 times, most recently from 2743543 to 596612e Compare August 6, 2019 19:39
@vlad20012
Copy link
Member

👍
bors r+

bors bot added a commit that referenced this pull request Aug 6, 2019
4207: COMP: Substitute types in completion variants r=vlad20012 a=mchernyavsky

![image](https://user-images.githubusercontent.com/6079006/62247623-df36a700-b3ee-11e9-9b69-6cb6439872f8.png)

Co-authored-by: Mikhail Chernyavsky <chemike47@gmail.com>
Co-authored-by: mchernyavsky <mikhail.chernyavsky@jetbrains.com>
@bors
Copy link
Contributor

bors bot commented Aug 6, 2019

Build failed

@mchernyavsky
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request Aug 6, 2019
4207: COMP: Substitute types in completion variants r=vlad20012 a=mchernyavsky

![image](https://user-images.githubusercontent.com/6079006/62247623-df36a700-b3ee-11e9-9b69-6cb6439872f8.png)

Co-authored-by: Mikhail Chernyavsky <chemike47@gmail.com>
Co-authored-by: mchernyavsky <mikhail.chernyavsky@jetbrains.com>
@bors
Copy link
Contributor

bors bot commented Aug 6, 2019

Build failed

@mchernyavsky
Copy link
Member Author

bors r=vlad20012

bors bot added a commit that referenced this pull request Aug 6, 2019
4207: COMP: Substitute types in completion variants r=vlad20012 a=mchernyavsky

![image](https://user-images.githubusercontent.com/6079006/62247623-df36a700-b3ee-11e9-9b69-6cb6439872f8.png)

Co-authored-by: Mikhail Chernyavsky <chemike47@gmail.com>
Co-authored-by: mchernyavsky <mikhail.chernyavsky@jetbrains.com>
@bors
Copy link
Contributor

bors bot commented Aug 6, 2019

@bors bors bot merged commit 587bc88 into master Aug 6, 2019
@bors bors bot deleted the subst-ty-lookup-elements branch August 6, 2019 22:58
@Undin Undin added this to the v104 milestone Aug 7, 2019
@Undin Undin added this to Test in To test Aug 7, 2019
@lancelote lancelote moved this from Test to Done in To test Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants