New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMP: Substitute types in completion variants #4207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mchernyavsky
commented
Jul 31, 2019
•
edited by Undin
edited by Undin
mchernyavsky
force-pushed
the
subst-ty-lookup-elements
branch
from
August 1, 2019 14:42
e2de2ab
to
7f393a3
Compare
mchernyavsky
changed the title
WIP: Substitute types in lookup elements
WIP: Substitute types in completion variants
Aug 1, 2019
mchernyavsky
force-pushed
the
subst-ty-lookup-elements
branch
2 times, most recently
from
August 2, 2019 03:58
3178706
to
989536c
Compare
mchernyavsky
changed the title
WIP: Substitute types in completion variants
COMP: Substitute types in completion variants
Aug 2, 2019
mchernyavsky
force-pushed
the
subst-ty-lookup-elements
branch
5 times, most recently
from
August 6, 2019 19:39
2743543
to
596612e
Compare
mchernyavsky
force-pushed
the
subst-ty-lookup-elements
branch
from
August 6, 2019 20:49
596612e
to
587bc88
Compare
👍 |
bors bot
added a commit
that referenced
this pull request
Aug 6, 2019
4207: COMP: Substitute types in completion variants r=vlad20012 a=mchernyavsky ![image](https://user-images.githubusercontent.com/6079006/62247623-df36a700-b3ee-11e9-9b69-6cb6439872f8.png) Co-authored-by: Mikhail Chernyavsky <chemike47@gmail.com> Co-authored-by: mchernyavsky <mikhail.chernyavsky@jetbrains.com>
Build failed |
bors retry |
bors bot
added a commit
that referenced
this pull request
Aug 6, 2019
4207: COMP: Substitute types in completion variants r=vlad20012 a=mchernyavsky ![image](https://user-images.githubusercontent.com/6079006/62247623-df36a700-b3ee-11e9-9b69-6cb6439872f8.png) Co-authored-by: Mikhail Chernyavsky <chemike47@gmail.com> Co-authored-by: mchernyavsky <mikhail.chernyavsky@jetbrains.com>
Build failed |
bors r=vlad20012 |
bors bot
added a commit
that referenced
this pull request
Aug 6, 2019
4207: COMP: Substitute types in completion variants r=vlad20012 a=mchernyavsky ![image](https://user-images.githubusercontent.com/6079006/62247623-df36a700-b3ee-11e9-9b69-6cb6439872f8.png) Co-authored-by: Mikhail Chernyavsky <chemike47@gmail.com> Co-authored-by: mchernyavsky <mikhail.chernyavsky@jetbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.