PERF: reduce PSI tree access in very hot item resolution #4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad20012
force-pushed
the
perf-name-resolution-cached-items
branch
from
6a9be94
to
279d096
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 5, 2019
4210: PERF: reduce PSI tree access in very hot item resolution r=vlad20012 a=vlad20012 Depends on #4190 This speeds up highlighting up to 5% (the baseline is before #4179) The approach is similar to #4182 - make more things accessible by one cache key and retrieve them together to reduce **PSI** (in the case of this PR) and cache access in very hot code. Co-authored-by: vlad20012 <beskvlad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up highlighting up to 5% (the baseline is before #4179)
The approach is similar to #4182 - make more things accessible by one cache key and retrieve them together to reduce PSI (in the case of this PR) and cache access in very hot code.