Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACT & UI: Cargo tool window enhancements #4287

Merged
merged 3 commits into from Sep 16, 2019
Merged

Conversation

mchernyavsky
Copy link
Member

@mchernyavsky mchernyavsky commented Aug 20, 2019

Various improvements of Cargo tool window:

  • "Expand All" and "Collapse All" buttons
  • "Toggle Offline Mode" action / button
  • "Cargo Settings" action / button

Cargo tool window

  • Before
    изображение

  • After
    изображение

For comparison, Gradle tool window:
изображение

@mchernyavsky mchernyavsky added feature to be documented Pull requests that should be documented labels Aug 20, 2019
@mchernyavsky mchernyavsky added this to the v105 milestone Aug 20, 2019
@mchernyavsky mchernyavsky added this to In Progress in To test via automation Aug 20, 2019
@Undin Undin self-assigned this Aug 21, 2019
@mchernyavsky mchernyavsky modified the milestones: v105, v106 Sep 2, 2019
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Undin
Copy link
Member

Undin commented Sep 13, 2019

@mchernyavsky could you, please, update screenshots? Now they are outdated because we dropped ToggleOfflineAction from cargo toolwindow

@mchernyavsky
Copy link
Member Author

Fixed.

Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Sep 16, 2019
4287: ACT & UI: Cargo tool window enhancments r=Undin a=mchernyavsky

Various improvements of Cargo tool window:
* "Expand All" and "Collapse All" buttons
* ~"Toggle Offline Mode" action / button~
* "Cargo Settings" action / button

Cargo tool window
* Before
    <img width="169" alt="изображение" src="https://user-images.githubusercontent.com/6079006/63378744-9180df00-c39b-11e9-92bc-516ed8fe6083.png">

* After
    <img width="260" alt="изображение" src="https://user-images.githubusercontent.com/6079006/64868154-72e2d080-d647-11e9-8673-06425394b9b9.png">



For comparison, Gradle tool window:
<img width="268" alt="изображение" src="https://user-images.githubusercontent.com/6079006/63378184-592cd100-c39a-11e9-84f1-2e703b1a88e8.png">


Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com>
@bors
Copy link
Contributor

bors bot commented Sep 16, 2019

Build failed

@Undin
Copy link
Member

Undin commented Sep 16, 2019

bors retry

bors bot added a commit that referenced this pull request Sep 16, 2019
4287: ACT & UI: Cargo tool window enhancments r=Undin a=mchernyavsky

Various improvements of Cargo tool window:
* "Expand All" and "Collapse All" buttons
* ~"Toggle Offline Mode" action / button~
* "Cargo Settings" action / button

Cargo tool window
* Before
    <img width="169" alt="изображение" src="https://user-images.githubusercontent.com/6079006/63378744-9180df00-c39b-11e9-92bc-516ed8fe6083.png">

* After
    <img width="260" alt="изображение" src="https://user-images.githubusercontent.com/6079006/64868154-72e2d080-d647-11e9-8673-06425394b9b9.png">



For comparison, Gradle tool window:
<img width="268" alt="изображение" src="https://user-images.githubusercontent.com/6079006/63378184-592cd100-c39a-11e9-84f1-2e703b1a88e8.png">


Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com>
@bors
Copy link
Contributor

bors bot commented Sep 16, 2019

@bors bors bot merged commit f4bb0ba into master Sep 16, 2019
To test automation moved this from In Progress to Test Sep 16, 2019
@bors bors bot deleted the cargo-toolwindow-enhancments branch September 16, 2019 21:47
@lancelote lancelote moved this from Test to Done in To test Sep 22, 2019
@mchernyavsky mchernyavsky changed the title ACT & UI: Cargo tool window enhancments ACT & UI: Cargo tool window enhancements Sep 24, 2019
@MarinaKalashina MarinaKalashina removed the to be documented Pull requests that should be documented label Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants