Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Navigate Class/Symbol" works with items expanded from macros #4291

Merged
merged 1 commit into from Aug 28, 2019

Conversation

vlad20012
Copy link
Member

Screenshot from 2019-08-21 13-54-28

Note that looks like I already enabled search for items expanded from macros in the case of "All places" scope in #4275. But this PR enables it correctly for all scopes (e.g. project/library files)

@artemmukhin
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Aug 28, 2019
4291: Make "Navigate Class/Symbol" works with items expanded from macros r=ortem a=vlad20012

![Screenshot from 2019-08-21 13-54-28](https://user-images.githubusercontent.com/3221931/63426571-d9dfe180-c41b-11e9-86b7-9b6fc192eee8.png)

Note that looks like I already enabled search for items expanded from macros in the case of "All places" scope in #4275. But this PR enables it correctly for all scopes (e.g. project/library files)

Co-authored-by: vlad20012 <beskvlad@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 28, 2019

@bors bors bot merged commit 02f3bab into master Aug 28, 2019
@bors bors bot deleted the go-to-class-symbol-in-macros branch August 28, 2019 17:23
@Undin Undin added this to the v105 milestone Aug 28, 2019
@Undin Undin added this to In Progress in To test via automation Aug 28, 2019
@Undin Undin added the feature label Aug 28, 2019
@Undin Undin moved this from In Progress to Test in To test Sep 8, 2019
@lancelote lancelote moved this from Test to Done in To test Sep 9, 2019
@lancelote
Copy link
Member

Hm, I was sure I did comment on this 🤔 Anyway, @vlad20012 is goto declaration expected to work in the following case:

macro_rules! foo {
    () => {
        struct FooBarBaz;
    };
}

fn main() {
    foo!();
}

Or is it too much?

@vlad20012
Copy link
Member Author

@lancelote too much :)
Macros inside function bodies are not indexed. In theory, we can simply enable it, but I expect a significant performance regression in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants