Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF&GRAM: make macros lazy parseable & reparseable #4357

Merged
merged 1 commit into from Sep 7, 2019
Merged

PERF&GRAM: make macros lazy parseable & reparseable #4357

merged 1 commit into from Sep 7, 2019

Conversation

vlad20012
Copy link
Member

PoC implementation of lazy parsing, Most likely this doesn't affect users anyhow.
Part of #4355

@vlad20012 vlad20012 added the internal Pull requests about internal improvements/fixes that don't affect users directly label Sep 5, 2019
@vlad20012 vlad20012 mentioned this pull request Sep 5, 2019
Closed
3 tasks
@vlad20012 vlad20012 force-pushed the lazy-parseable-macros branch 2 times, most recently from ac849ae to c2ca074 Compare September 6, 2019 15:53
@vlad20012
Copy link
Member Author

Made macro call bodies non-reparseable because of problems with builtin macros

Undin
Undin approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/main/grammars/RustParser.bnf Outdated Show resolved Hide resolved
src/main/grammars/RustParser.bnf Outdated Show resolved Hide resolved
src/main/kotlin/org/rust/lang/core/parser/RustParserUtil.kt Outdated Show resolved Hide resolved
@Undin Undin added this to the v106 milestone Sep 7, 2019
Undin
Undin approved these changes Sep 7, 2019
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Sep 7, 2019
@bors @vlad20012
Merge #4357
4a63380 
4357: PERF&GRAM: make macros lazy parseable & reparseable r=Undin a=vlad20012

PoC implementation of lazy parsing, Most likely this doesn't affect users anyhow.
Part of #4355

Co-authored-by: vlad20012 <beskvlad@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 7, 2019

Build failed

@vlad20012
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request Sep 7, 2019
@bors @vlad20012
Merge #4357
8f428a6 
4357: PERF&GRAM: make macros lazy parseable & reparseable r=Undin a=vlad20012

PoC implementation of lazy parsing, Most likely this doesn't affect users anyhow.
Part of #4355

Co-authored-by: vlad20012 <beskvlad@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 7, 2019

Build succeeded

@bors bors bot merged commit 6c7efb9 into intellij-rust:master Sep 7, 2019
@vlad20012 vlad20012 deleted the lazy-parseable-macros branch September 7, 2019 13:42
@vlad20012 vlad20012 mentioned this pull request Jan 26, 2020
Merged
bors bot added a commit that referenced this pull request Jan 27, 2020
@bors @vlad20012
Merge #4877
44df99b 
4877: PERF: make macro call body reparseable r=vlad20012 a=vlad20012

Finish the work started in #4357 (using infrastructure from #4491). Most likely this doesn't affect users anyhow but can speed up completion in macro call in large files

Co-authored-by: vlad20012 <beskvlad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Undin Undin Undin approved these changes

Assignees
No one assigned
Labels
internal Pull requests about internal improvements/fixes that don't affect users directly
Projects
None yet
Milestone
v106
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vlad20012 @Undin