Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CARGO: fix NPE while parsing of rustc commit date #4374

Merged
merged 1 commit into from Sep 10, 2019
Merged

CARGO: fix NPE while parsing of rustc commit date #4374

merged 1 commit into from Sep 10, 2019

Conversation

Undin
Copy link
Member

@Undin Undin commented Sep 10, 2019 •
edited

Also, add some tests of rustc version parsing

Fixes #4372

@Undin
CARGO: fix NPE while parsing of rustc commit date
2c8b13d 
Also, add come tests of rustc version parsing
@Undin Undin added the fix Pull requests that fix some bug(s) label Sep 10, 2019
@Undin Undin added this to the v106 milestone Sep 10, 2019
@Undin Undin added this to In Progress in To test via automation Sep 10, 2019
@Undin Undin assigned vlad20012 and mchernyavsky and unassigned vlad20012 Sep 10, 2019
mchernyavsky
mchernyavsky approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Sep 10, 2019
@bors @Undin
Merge #4374
e50c97d 
4374: CARGO: fix NPE while parsing of rustc commit date r=mchernyavsky a=Undin

Also, add some tests of rustc version parsing

Fixes #4372

Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
@bors
Copy link
Contributor

bors bot commented Sep 10, 2019

Build succeeded

@bors bors bot merged commit 2c8b13d into master Sep 10, 2019
To test automation moved this from In Progress to Test Sep 10, 2019
@bors bors bot deleted the fix-npe-while-date-parsing branch September 10, 2019 13:36
@lancelote lancelote moved this from Test to Done in To test Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchernyavsky mchernyavsky mchernyavsky approved these changes

Assignees

@mchernyavsky mchernyavsky

Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v106
Development

Successfully merging this pull request may close these issues.

NullPointerException in scrapeRustcVersion
3 participants
@Undin @mchernyavsky @vlad20012