Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MACRO: check macro expansion depth during type inference #4383

Merged
merged 1 commit into from Sep 15, 2019
Merged

MACRO: check macro expansion depth during type inference #4383

merged 1 commit into from Sep 15, 2019

Conversation

vlad20012
Copy link
Member

Prevents infinite recursive macros.
(More generic fix for #4375)

@vlad20012 vlad20012 force-pushed the macro-expr-check-recursion-depth branch from 00edaf1 to 8824db2 Compare September 12, 2019 14:15
@vlad20012 vlad20012 force-pushed the macro-expr-check-recursion-depth branch from 8824db2 to d5399e3 Compare September 12, 2019 15:14
@vlad20012
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Sep 14, 2019
@bors @vlad20012
Merge #4383
0394eba 
4383: MACRO: check macro expansion depth during type inference r=vlad20012 a=vlad20012

Prevents infinite recursive macros.
(More generic fix for #4375)

Co-authored-by: vlad20012 <beskvlad@gmail.com>
@vlad20012 vlad20012 added this to the v106 milestone Sep 14, 2019
@vlad20012 vlad20012 added the fix Pull requests that fix some bug(s) label Sep 14, 2019
@vlad20012
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 14, 2019

Already running a review

@Undin
Copy link
Member

Undin commented Sep 14, 2019

bors r-

@bors
Copy link
Contributor

bors bot commented Sep 14, 2019

Canceled

@Undin
Copy link
Member

Undin commented Sep 14, 2019

bors r=vlad20012

bors bot added a commit that referenced this pull request Sep 14, 2019
@bors @vlad20012
Merge #4383
8c2c722 
4383: MACRO: check macro expansion depth during type inference r=vlad20012 a=vlad20012

Prevents infinite recursive macros.
(More generic fix for #4375)

Co-authored-by: vlad20012 <beskvlad@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 14, 2019

Build failed

@Undin
Copy link
Member

Undin commented Sep 15, 2019

bors retry

bors bot added a commit that referenced this pull request Sep 15, 2019
@bors @vlad20012
Merge #4383
ea14d80 
4383: MACRO: check macro expansion depth during type inference r=vlad20012 a=vlad20012

Prevents infinite recursive macros.
(More generic fix for #4375)

Co-authored-by: vlad20012 <beskvlad@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 15, 2019

Build succeeded

@bors bors bot merged commit d5399e3 into master Sep 15, 2019
@bors bors bot deleted the macro-expr-check-recursion-depth branch September 15, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Undin Undin Undin left review comments

Assignees
No one assigned
Labels
fix Pull requests that fix some bug(s)
Projects
None yet
Milestone
v106
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vlad20012 @Undin