Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUN: Don't activate Build Tool Window if "Activate tool window" option is disabled #4550

Merged
merged 1 commit into from Jan 15, 2021
Merged

RUN: Don't activate Build Tool Window if "Activate tool window" option is disabled #4550

merged 1 commit into from Jan 15, 2021

Conversation

mchernyavsky
Copy link
Member

@mchernyavsky mchernyavsky commented Oct 22, 2019 •
edited by Undin

Closes #4535.

@mchernyavsky mchernyavsky added the fix Pull requests that fix some bug(s) label Oct 22, 2019
Undin
Undin reviewed Oct 27, 2019
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build tool window is still shown with disabled "Activate tool window" option

src/main/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildManager.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildTaskProvider.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildManager.kt Outdated Show resolved Hide resolved
@mchernyavsky mchernyavsky force-pushed the mchernyavsky/activate-toolwindow branch from 58ae3eb to 5511f64 Compare October 27, 2019 15:53
@mchernyavsky
Copy link
Member Author

@Undin Fixed.

Undin
Undin reviewed Oct 28, 2019
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the following exception after build finishes

java.lang.NullPointerException
	at com.intellij.build.BuildTreeConsoleView.getOrCreateMessagesNode(BuildTreeConsoleView.java:720)
	at com.intellij.build.BuildTreeConsoleView.createMessageParentNodes(BuildTreeConsoleView.java:632)
	at com.intellij.build.BuildTreeConsoleView.getOrMaybeCreateParentNode(BuildTreeConsoleView.java:238)
	at com.intellij.build.BuildTreeConsoleView.onEventInternal(BuildTreeConsoleView.java:244)
	at com.intellij.build.BuildTreeConsoleView.lambda$onEvent$15(BuildTreeConsoleView.java:609)
	at com.intellij.openapi.application.impl.ApplicationImpl.tryRunReadAction(ApplicationImpl.java:1106)
	at com.intellij.openapi.progress.util.ProgressIndicatorUtils.lambda$runInReadActionWithWriteActionPriority$0(ProgressIndicatorUtils.java:72)
	at com.intellij.openapi.progress.util.ProgressIndicatorUtils.lambda$runWithWriteActionPriority$1(ProgressIndicatorUtils.java:126)
	at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$2(CoreProgressManager.java:169)
	at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:591)
	at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:537)
	at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:59)
	at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:156)
	at com.intellij.openapi.progress.util.ProgressIndicatorUtils.runWithWriteActionPriority(ProgressIndicatorUtils.java:115)
	at com.intellij.openapi.progress.util.ProgressIndicatorUtils.runInReadActionWithWriteActionPriority(ProgressIndicatorUtils.java:72)
	at com.intellij.util.concurrency.Invoker.invokeSafely(Invoker.java:153)
	at com.intellij.util.concurrency.Invoker.lambda$invokeLater$0(Invoker.java:91)
	at com.intellij.util.concurrency.Invoker$BackgroundThread.lambda$offer$0(Invoker.java:320)
	at com.intellij.util.concurrency.BoundedTaskExecutor.doRun(BoundedTaskExecutor.java:207)
	at com.intellij.util.concurrency.BoundedTaskExecutor.access$100(BoundedTaskExecutor.java:29)
	at com.intellij.util.concurrency.BoundedTaskExecutor$1.lambda$run$0(BoundedTaskExecutor.java:185)
	at com.intellij.util.ConcurrencyUtil.runUnderThreadName(ConcurrencyUtil.java:208)
	at com.intellij.util.concurrency.BoundedTaskExecutor$1.run(BoundedTaskExecutor.java:181)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

src/main/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildManager.kt Outdated Show resolved Hide resolved
@mchernyavsky mchernyavsky force-pushed the mchernyavsky/activate-toolwindow branch from 5511f64 to c71cfdc Compare October 28, 2019 19:37
@mchernyavsky
Copy link
Member Author

I get the following exception after build finishes

@Undin Can you please provide a sample project, if the error is still here?

Undin
Undin reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase onto master to fix merge conflicts, please?

@mchernyavsky mchernyavsky force-pushed the mchernyavsky/activate-toolwindow branch from c71cfdc to 3478ca5 Compare December 18, 2020 16:51
@mchernyavsky
Copy link
Member Author

@Undin Done.

Undin
Undin requested changes Jan 3, 2021
View reviewed changes
Copy link
Member

@Undin Undin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

src/main/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildAdapter.kt Outdated Show resolved Hide resolved
src/main/kotlin/org/rust/cargo/runconfig/buildtool/CargoBuildAdapter.kt Outdated Show resolved Hide resolved
@Undin Undin added this to In Progress in To test via automation Jan 3, 2021
@mchernyavsky mchernyavsky force-pushed the mchernyavsky/activate-toolwindow branch from 3478ca5 to 5c2dec5 Compare January 13, 2021 22:12
@mchernyavsky
Copy link
Member Author

@Undin Fixed.

Undin
Undin approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
bors r+

@Undin Undin added this to the v140 milestone Jan 15, 2021
@bors
Copy link
Contributor

bors bot commented Jan 15, 2021

Build succeeded:

@bors bors bot merged commit 2041ec3 into master Jan 15, 2021
To test automation moved this from In Progress to Test Jan 15, 2021
@bors bors bot deleted the mchernyavsky/activate-toolwindow branch January 15, 2021 16:24
@lancelote lancelote moved this from Test to Done in To test Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Undin Undin Undin approved these changes

Assignees

@Undin Undin

Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v140
Development

Successfully merging this pull request may close these issues.

Cargo run configurations don't take into account "Activate tool window" option
2 participants
@mchernyavsky @Undin