Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANN: Detect invalid default type parameter usage #4670

Merged
merged 1 commit into from Nov 25, 2019
Merged

ANN: Detect invalid default type parameter usage #4670

merged 1 commit into from Nov 25, 2019

Conversation

rrevenantt
Copy link
Contributor

No description provided.

@Undin Undin added the feature label Nov 21, 2019
@Undin Undin added this to In Progress in To test via automation Nov 21, 2019
@mchernyavsky mchernyavsky self-assigned this Nov 22, 2019
mchernyavsky
mchernyavsky approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@mchernyavsky mchernyavsky added this to the v111 milestone Nov 25, 2019
bors bot added a commit that referenced this pull request Nov 25, 2019
@bors @artemmukhin @rrevenantt
Merge #4634 #4670
6afc26f 
4634: Fix ConvertToTyUsingFromTraitFix on types that cannot be paths r=mchernyavsky a=ortem

Fixes #4633

4670: ANN: Detect invalid default type parameter usage r=mchernyavsky a=rrevenantt



Co-authored-by: ortem <ortem00@gmail.com>
Co-authored-by: Konstantin Anisimov <rrevenantt@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 25, 2019

Build failed (retrying...)

bors bot added a commit that referenced this pull request Nov 25, 2019
@bors @rrevenantt
Merge #4670
83c7b92 
4670: ANN: Detect invalid default type parameter usage r=mchernyavsky a=rrevenantt



Co-authored-by: Konstantin Anisimov <rrevenantt@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 25, 2019

Build succeeded

@bors bors bot merged commit 3c5fdda into intellij-rust:master Nov 25, 2019
To test automation moved this from In Progress to Test Nov 25, 2019
@lancelote lancelote moved this from Test to Done in To test Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchernyavsky mchernyavsky mchernyavsky approved these changes

Assignees

@mchernyavsky mchernyavsky

Labels
feature
Projects
To test
  
Done
Milestone
v111
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rrevenantt @mchernyavsky @Undin