Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT: fix ConvertToNamedFields handling of function calls #5019

Merged
merged 1 commit into from Feb 29, 2020

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Feb 27, 2020

This PR changes ConvertToNamedFields so that it doesn't try to convert all function calls to a named struct literal.

Fixes: #5017

@Undin Undin added the fix Pull requests that fix some bug(s) label Feb 29, 2020
@Undin Undin added this to In Progress in To test via automation Feb 29, 2020
@Undin Undin added this to the v118 milestone Feb 29, 2020
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok
Thanks!
bors r+

@Undin Undin self-assigned this Feb 29, 2020
@bors
Copy link
Contributor

bors bot commented Feb 29, 2020

Build succeeded

@bors bors bot merged commit bd2e05f into intellij-rust:master Feb 29, 2020
To test automation moved this from In Progress to Test Feb 29, 2020
@Kobzol Kobzol deleted the convert-to-named-fix branch February 29, 2020 18:24
@lancelote lancelote moved this from Test to Done in To test Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

Convert to block struct refactor is overeager
2 participants