ANN: show type errors for references containing unknown types if mutability differs #5548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
type-check-ref-mut
branch
from
965b82d
to
e4ee25c
Compare
Kobzol
force-pushed
the
type-check-ref-mut
branch
from
e4ee25c
to
987eed6
Compare
bors bot
added a commit
that referenced
this pull request
Jun 17, 2020
5550: INSP: add quick fix to convert immutable reference to mutable reference r=mchernyavsky a=Kobzol This PR adds a quick fix to convert an immutable reference to a mutable one:  The last test should be enabled if/after #5548 gets merged. Umbrella issue: #1730 Fixes: #2472 Co-authored-by: Jakub Beránek <berykubik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes error annotation to show a type error if you give an immutable reference where a mutable reference is expected, even if the type behind the reference is not fully resolved. I think that this is useful, because even if the types are unresolved, passing
&where&mutis expected will be an error in any case and if we show the annotation (and solve it with a quick fix, that I'll send a separate PR for), it can help with actually resolving the type (this happens in the linked issue).Fixes: #4705