Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QDOC: fix some corner cases in doc rendered #5669

Merged
merged 1 commit into from Jul 2, 2020
Merged

QDOC: fix some corner cases in doc rendered #5669

merged 1 commit into from Jul 2, 2020

Conversation

Undin
Copy link
Member

@Undin Undin commented Jun 28, 2020

  • properly handle single # lines
  • don't take into account spaces before #

Fixes #5631

@Undin
#5631: fix some corner cases in doc rendered
a1eb4d0 
* properly handle single `#` lines
* don't take into account spaces before `#`
@Undin Undin added the fix Pull requests that fix some bug(s) label Jun 28, 2020
@Undin Undin added this to In Progress in To test via automation Jun 28, 2020
mchernyavsky
mchernyavsky approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@mchernyavsky mchernyavsky added this to the v126 milestone Jul 2, 2020
@bors
Copy link
Contributor

bors bot commented Jul 2, 2020

Build succeeded:

@bors bors bot merged commit be00f0e into master Jul 2, 2020
To test automation moved this from In Progress to Test Jul 2, 2020
@bors bors bot deleted the undin/5631-fix-code-snipper-rendering branch July 2, 2020 02:33
@lancelote lancelote moved this from Test to Done in To test Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchernyavsky mchernyavsky mchernyavsky approved these changes

Assignees

@mchernyavsky mchernyavsky

Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v126
Development

Successfully merging this pull request may close these issues.

#-prefixed lines are not shown in example doc section on tooltip
2 participants
@Undin @mchernyavsky