INSP: add inspection to check associated type bindings #5866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
insp-associated-type-arguments
branch
from
2b004c1
to
9134154
Compare
|
Rebased over |
|
Checked the rest of the real projects locally, fixed some false positives. |
Kobzol
force-pushed
the
insp-associated-type-arguments
branch
3 times, most recently
from
738eec6
to
eaeecee
Compare
|
Seems that false positives on CI were resolved. |
Kobzol
force-pushed
the
insp-associated-type-arguments
branch
4 times, most recently
from
5b0ba48
to
898fb02
Compare
|
Finally looks like all tests passed and regressions disappeared, at least for now :D |
Kobzol
force-pushed
the
insp-associated-type-arguments
branch
from
898fb02
to
e4a8b7d
Compare
Kobzol
force-pushed
the
insp-associated-type-arguments
branch
from
e4a8b7d
to
fdbfc8e
Compare
|
Rebased on |
Kobzol
force-pushed
the
insp-associated-type-arguments
branch
from
fdbfc8e
to
f90b8e4
Compare
Kobzol
force-pushed
the
insp-associated-type-arguments
branch
from
f90b8e4
to
8cf90b4
Compare
|
@Kobzol could you please rebase on master |
Kobzol
force-pushed
the
insp-associated-type-arguments
branch
from
8cf90b4
to
d7de449
Compare
Kobzol
force-pushed
the
insp-associated-type-arguments
branch
from
d7de449
to
ef2a8cb
Compare
|
Done. |
dima74
force-pushed
the
insp-associated-type-arguments
branch
from
ef2a8cb
to
736cf76
Compare
dima74
reviewed
Sep 8, 2022
src/main/kotlin/org/rust/ide/inspections/RsWrongAssocTypeArgumentsInspection.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/inspections/RsWrongAssocTypeArgumentsInspection.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/inspections/RsWrongAssocTypeArgumentsInspection.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/inspections/RsWrongAssocTypeArgumentsInspection.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/inspections/fixes/RemoveAssocTypeBindingFix.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/inspections/RsWrongAssocTypeArgumentsInspection.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/inspections/fixes/AddAssocTypeBindingsFix.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/inspections/fixes/AddAssocTypeBindingsFix.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/inspections/fixes/AddAssocTypeBindingsFix.kt
Outdated
Show resolved
Hide resolved
dima74
reviewed
Sep 8, 2022
src/main/kotlin/org/rust/ide/inspections/fixes/AddAssocTypeBindingsFix.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/inspections/fixes/AddAssocTypeBindingsFix.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/rust/ide/inspections/RsWrongAssocTypeArgumentsInspection.kt
Outdated
Show resolved
Hide resolved
Kobzol
force-pushed
the
insp-associated-type-arguments
branch
from
1c325c8
to
38395bf
Compare
|
I tried to refactor it, let me know if it's ok :) |
dima74
reviewed
Sep 26, 2022
src/main/kotlin/org/rust/ide/inspections/RsWrongAssocTypeArgumentsInspection.kt
Outdated
Show resolved
Hide resolved
Kobzol
force-pushed
the
insp-associated-type-arguments
branch
from
38395bf
to
0c75aca
Compare
|
Done. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an inspection and two quick fixes (add missing associated types, remove unknown associated types) that handle missing/erroneous associated type bindings.
There is some very similar code between
AddAssocTypeBindingsFixandAddTypeArgumentsFix, which handles inserting new items into type arguments. Should it be extracted? If yes, where?Related: #886