Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INSP: don't apply RsStaticConstNamingInspection for extern statics #6024

Merged
merged 1 commit into from Aug 29, 2020
Merged

INSP: don't apply RsStaticConstNamingInspection for extern statics #6024

merged 1 commit into from Aug 29, 2020

Conversation

Undin
Copy link
Member

@Undin Undin commented Aug 28, 2020

Fixes #6023

@Undin Undin added the fix Pull requests that fix some bug(s) label Aug 28, 2020
@Undin Undin requested a review from Kobzol August 28, 2020 23:47
@Undin Undin added this to In Progress in To test via automation Aug 28, 2020
@Undin Undin removed the request for review from Kobzol August 28, 2020 23:49
Kobzol
Kobzol approved these changes Aug 29, 2020
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Undin
Copy link
Member Author

Undin commented Aug 29, 2020

bors r=Kobzol

@Undin Undin added this to the v130 milestone Aug 29, 2020
@vlad20012
Copy link
Member

Should associated constants be checked? Looks like this PR exclude them

@Kobzol
Copy link
Member

Kobzol commented Aug 29, 2020

AFAIK this is only about statics, and these cannot be associated. Constants are checked by a different lint, because they use a different lint message.

@Undin
Copy link
Member Author

Undin commented Aug 29, 2020 •
edited

Should associated constants be checked? Looks like this PR exclude them

Yep, it's only about statics

@bors
Copy link
Contributor

bors bot commented Aug 29, 2020

Build succeeded:

@bors bors bot merged commit 29cbd07 into master Aug 29, 2020
To test automation moved this from In Progress to Test Aug 29, 2020
@bors bors bot deleted the undin/6023-extern-static branch August 29, 2020 08:07
@lancelote lancelote moved this from Test to Done in To test Sep 7, 2020
@Undin Undin mentioned this pull request Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol approved these changes

Assignees

@Kobzol Kobzol

Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v130
Development

Successfully merging this pull request may close these issues.

RsStaticConstNaming shouldn't inspect extern statics
3 participants
@Undin @vlad20012 @Kobzol