Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANN: highlight arguments of panic macro #6120

Merged
merged 1 commit into from Dec 24, 2020
Merged

ANN: highlight arguments of panic macro #6120

merged 1 commit into from Dec 24, 2020

Conversation

Undin
Copy link
Member

@Undin Undin commented Sep 16, 2020

Closes #6119

@Undin Undin added the feature label Sep 16, 2020
@Undin Undin added this to In Progress in To test via automation Sep 16, 2020
@Kobzol
Copy link
Member

Kobzol commented Sep 17, 2020

LGTM. Supporting debug! and others could possibly be done by resolving the macro call and checking if it ends up in log/tracing crates?

@Undin Undin marked this pull request as ready for review December 24, 2020 17:37
@Undin
Copy link
Member Author

Undin commented Dec 24, 2020

bors r=Kobzol

@bors
Copy link
Contributor

bors bot commented Dec 24, 2020

Build succeeded:

@bors bors bot merged commit a670da3 into master Dec 24, 2020
To test automation moved this from In Progress to Test Dec 24, 2020
@bors bors bot deleted the undin/highligh-panic-macro branch December 24, 2020 19:37
@github-actions github-actions bot added this to the v139 milestone Dec 24, 2020
@Undin Undin mentioned this pull request Jan 9, 2021
Closed
@lancelote lancelote moved this from Test to Done in To test Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol approved these changes

Assignees

@Kobzol Kobzol

Labels
feature
Projects
To test
  
Done
Milestone
v139
Development

Successfully merging this pull request may close these issues.

Color of brackets in panic!() issue
2 participants
@Undin @Kobzol