Fix exception in the cargo toolwindow init #6125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like `runAfterOpened` can run outside of EDT
bors bot
added a commit
that referenced
this pull request
Sep 17, 2020
6125: Fix exception in the cargo toolwindow init r=mchernyavsky a=vlad20012 Fix for #5999. Looks like `runAfterOpened` can run outside of EDT. <details> <summary>Stacktrace</summary> ``` Access is allowed from event dispatch thread with IW lock only. com.intellij.openapi.diagnostic.RuntimeExceptionWithAttachments: EventQueue.isDispatchThread()=false Toolkit.getEventQueue()=com.intellij.ide.IdeEventQueue@6d984235 Current thread: Thread[ApplicationImpl pooled thread 11,4,Idea Thread Group] 1697154984 SystemEventQueueThread: Thread[AWT-EventQueue-0,6,Idea Thread Group] 1894364389 at com.intellij.openapi.application.impl.ApplicationImpl.assertIsDispatchThread(ApplicationImpl.java:1061) at com.intellij.openapi.application.impl.ApplicationImpl.assertIsDispatchThread(ApplicationImpl.java:1043) at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.doRegisterToolWindow(ToolWindowManagerImpl.kt:986) at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.initToolWindow(ToolWindowManagerImpl.kt:530) at com.intellij.openapi.wm.impl.ToolWindowManagerImpl.initToolWindow(ToolWindowManagerImpl.kt:512) at org.rust.cargo.project.toolwindow.CargoToolWindow$Companion.initializeToolWindow(CargoToolWindow.kt:151) at org.rust.cargo.project.model.impl.CargoProjectsServiceImpl$$special$$inlined$with$lambda$3$1.run(CargoProjectImpl.kt:106) at com.intellij.ide.startup.impl.StartupManagerImpl.runActivity(StartupManagerImpl.java:436) at com.intellij.ide.startup.impl.StartupManagerImpl.runActivities(StartupManagerImpl.java:392) at com.intellij.ide.startup.impl.StartupManagerImpl.runPostStartupActivitiesRegisteredDynamically(StartupManagerImpl.java:334) at com.intellij.ide.startup.impl.StartupManagerImpl.runPostStartupActivities(StartupManagerImpl.java:247) at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$2(CoreProgressManager.java:170) at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:629) at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:581) at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:60) at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:157) at com.intellij.openapi.progress.util.BackgroundTaskUtil.runUnderDisposeAwareIndicator(BackgroundTaskUtil.java:254) at com.intellij.ide.startup.impl.StartupManagerImpl.lambda$projectOpened$1(StartupManagerImpl.java:154) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:652) at java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:649) at java.security.AccessController.doPrivileged(Native Method) at java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:649) at java.lang.Thread.run(Thread.java:748) ``` </details> Co-authored-by: vlad20012 <beskvlad@gmail.com>
|
Build failed:
|
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #5999. Looks like
runAfterOpenedcan run outside of EDT.Stacktrace