Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INSP: Convert implicit trait type inspection into lint one #6167

Merged
merged 1 commit into from Sep 27, 2020
Merged

INSP: Convert implicit trait type inspection into lint one #6167

merged 1 commit into from Sep 27, 2020

Conversation

avrong
Copy link
Member

@avrong avrong commented Sep 27, 2020 •
edited

Made a lint inspection similar to #5890 by defining a new RsLint variant, inheriting from the RsLintInspection class and calling registerLintProblem inside it. Relative to comiler lint, renamed RsImplicitTraitObjectInspection into RsBareTraitObjectsInspection.

Part of #5888

@Undin Undin self-assigned this Sep 27, 2020
@Undin Undin added the feature label Sep 27, 2020
@Undin Undin added this to In Progress in To test via automation Sep 27, 2020
Undin
Undin approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except minor comment

src/test/kotlin/org/rust/ide/inspections/RsBareTraitObjectsInspectionTest.kt Show resolved Hide resolved
@Undin Undin added this to the v132 milestone Sep 27, 2020
@avrong
Copy link
Member Author

avrong commented Sep 27, 2020

bors r=Undin

@avrong avrong mentioned this pull request Sep 27, 2020
Open
112 tasks
@bors
Copy link
Contributor

bors bot commented Sep 27, 2020

Build succeeded:

@bors bors bot merged commit 62d2405 into intellij-rust:master Sep 27, 2020
To test automation moved this from In Progress to Test Sep 27, 2020
@avrong avrong deleted the bare-trait-objects-lint branch September 27, 2020 12:47
@lancelote lancelote moved this from Test to Done in To test Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Undin Undin Undin approved these changes

Assignees

@Undin Undin

Labels
feature
Projects
To test
  
Done
Milestone
v132
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@avrong @Undin