Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Find Usages action for Cargo features #6423

Merged
merged 1 commit into from Dec 7, 2020
Merged

Conversation

vlad20012
Copy link
Member

@vlad20012 vlad20012 commented Nov 23, 2020

Usage search works for Rust and TOML code. Related to #4693

With ctrl + B:
image

With alt + F7:
image

Usage highlighting:
Peek 2020-11-23 17-27

There is a bug with usage highlighting - now any key in any TOML file is highlighted as some definition when under the caret. But I've checked that YAML plugin has the same bug (or a feature?), so I don't think it's critical. I also found that this bug (feature?) can be fixed with a new Symbol API that is available on 2020.3 platform.

Peek 2020-11-23 17-53

@vlad20012 vlad20012 added this to In Progress in To test via automation Nov 23, 2020
@vlad20012 vlad20012 force-pushed the features-find-usages branch 3 times, most recently from 4ce3f0a to 29cba25 Compare November 23, 2020 18:57
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename doesn't work correctly in case of feature dependencies

2020-12-07 18 29 11

Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 7, 2020

Build succeeded:

@bors bors bot merged commit f4d8328 into master Dec 7, 2020
To test automation moved this from In Progress to Test Dec 7, 2020
@bors bors bot deleted the features-find-usages branch December 7, 2020 18:16
@github-actions github-actions bot added this to the v137 milestone Dec 7, 2020
@lancelote lancelote moved this from Test to Done in To test Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants