New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Find Usages
action for Cargo features
#6423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad20012
force-pushed
the
features-find-usages
branch
3 times, most recently
from
November 23, 2020 18:57
4ce3f0a
to
29cba25
Compare
10 tasks
vlad20012
force-pushed
the
features-find-usages
branch
from
November 26, 2020 09:11
29cba25
to
076c33a
Compare
vlad20012
force-pushed
the
features-find-usages
branch
from
December 7, 2020 14:29
076c33a
to
1ebe4ab
Compare
Undin
reviewed
Dec 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intellij-toml/src/main/kotlin/org/toml/ide/search/TomlFindUsagesProvider.kt
Outdated
Show resolved
Hide resolved
toml/src/main/kotlin/org/rust/toml/search/CargoTomlUsageTypeProvider.kt
Outdated
Show resolved
Hide resolved
toml/src/main/kotlin/org/rust/toml/search/CargoTomlUsageTypeProvider.kt
Outdated
Show resolved
Hide resolved
toml/src/main/kotlin/org/rust/toml/search/CargoTomlUsageTypeProvider.kt
Outdated
Show resolved
Hide resolved
toml/src/test/kotlin/org/rust/toml/search/CargoTomlFindUsagesTest.kt
Outdated
Show resolved
Hide resolved
toml/src/main/kotlin/org/rust/toml/search/CargoTomlUsageTypeProvider.kt
Outdated
Show resolved
Hide resolved
vlad20012
force-pushed
the
features-find-usages
branch
from
December 7, 2020 16:25
1ebe4ab
to
70ce118
Compare
Undin
approved these changes
Dec 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage search works for Rust and TOML code. Related to #4693
With
ctrl + B
:With
alt + F7
:Usage highlighting:
There is a bug with usage highlighting - now any key in any TOML file is highlighted as some definition when under the caret. But I've checked that YAML plugin has the same bug (or a feature?), so I don't think it's critical. I also found that this bug (feature?) can be fixed with a new
Symbol
API that is available on 2020.3 platform.