INSP: improve AttrWithoutParentheses: take into account `cfg_attr
#6440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad20012
force-pushed
the
toot-meta-item
branch
from
c52be82
to
27e7a7c
Compare
Undin
reviewed
Nov 27, 2020
vlad20012
force-pushed
the
toot-meta-item
branch
from
27e7a7c
to
902a64c
Compare
It returns `true` for top-level meta items like `#[foo]`, or for conditional attributes like `foo` `#[cfg_attr(windows, foo)]`
For now, this is just a test for `RsMetaItem.isRootMetaItem`, but it could be used in `RsAttributeCompletionProvider`, for example
vlad20012
force-pushed
the
toot-meta-item
branch
from
902a64c
to
60a6419
Compare
bors bot
added a commit
that referenced
this pull request
Nov 27, 2020
6440: INSP: improve `AttrWithoutParentheses`: take into account `cfg_attr r=Undin a=vlad20012 An improvement for #6413: take into account attributes in `#[cfg_attr(foobar, ...)]` c.c. @zeroeightysix changelog: Detect attributes that require parentheses but have no parentheses, and suggest Add parentheses quick-fix for attributes under #[cfg_attr] Co-authored-by: vlad20012 <beskvlad@gmail.com>
|
Build failed:
|
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Nov 27, 2020
6440: INSP: improve `AttrWithoutParentheses`: take into account `cfg_attr r=Undin a=vlad20012 An improvement for #6413: take into account attributes in `#[cfg_attr(foobar, ...)]` c.c. @zeroeightysix changelog: Detect attributes that require parentheses but have no parentheses, and suggest Add parentheses quick-fix for attributes under #[cfg_attr] Co-authored-by: vlad20012 <beskvlad@gmail.com>
|
Build failed:
|
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An improvement for #6413: take into account attributes in
#[cfg_attr(foobar, ...)]c.c. @zeroeightysix
changelog: Detect attributes that require parentheses but have no parentheses, and suggest Add parentheses quick-fix for attributes under #[cfg_attr]