Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT: add support for associated functions in CreateFunctionIntention #6471

Merged
merged 1 commit into from Jan 17, 2021
Merged

INT: add support for associated functions in CreateFunctionIntention #6471

merged 1 commit into from Jan 17, 2021

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Dec 2, 2020

This PR enables CreateFunctionIntention for associated methods.
associated-method

changelog: Enable CreateFunctionIntention also for associated methods.

@Kobzol Kobzol added the feature label Dec 2, 2020
@Kobzol Kobzol added this to In Progress in To test via automation Dec 2, 2020
@vlad20012
Copy link
Member

I think, in Rust it's usually called associated function, not associated method. There are multiple usages of this term across the PR

@Kobzol Kobzol changed the title INT: add support for associated methods in CreateFunctionIntention INT: add support for associated functions in CreateFunctionIntention Jan 16, 2021
@Kobzol Kobzol force-pushed the int-create-associated-function branch from d126b6b to c02504d Compare January 16, 2021 17:57
vlad20012
vlad20012 approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 17, 2021

Build succeeded:

@bors bors bot merged commit 004e240 into intellij-rust:master Jan 17, 2021
To test automation moved this from In Progress to Test Jan 17, 2021
@github-actions github-actions bot added this to the v140 milestone Jan 17, 2021
@Kobzol Kobzol deleted the int-create-associated-function branch January 17, 2021 13:42
@lancelote lancelote moved this from Test to Done in To test Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad20012 vlad20012 vlad20012 approved these changes

Assignees
No one assigned
Labels
feature
Projects
To test
  
Done
Milestone
v140
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kobzol @vlad20012