CI: set milestone automatically for PRs from forks #6538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undin
added
the
internal
|
bors merge |
|
Build succeeded: |
Undin
added a commit
that referenced
this pull request
Jan 13, 2021
#6538 changed event when milestone workflow triggered. Most important part of this change is that now we use base commit of each PR to determine milestone. It allows us to launch the workflow for any PR (even from forks) but at the same time it works incorrectly because now the workflow look on old version of `gradle.properties` files to get proper milestone version. These changes get actual content of `gradle.properties` via downloading it via http instead of using potentially outdated local version
bors bot
added a commit
that referenced
this pull request
Jan 14, 2021
6667: CI: set milestone properly from CI r=Undin a=Undin #6538 changed event when milestone workflow triggered. Most important part of this change is that now we use base commit of each PR to determine milestone. It allows us to launch the workflow for any PR (even from forks) but at the same time it works incorrectly because now the workflow look on old version of `gradle.properties` files to get proper milestone version. These changes get actual content of `gradle.properties` via downloading it via http instead of using potentially outdated local version <!-- Hello and thank you for the pull request! We don't have any strict rules about pull requests, but you might check https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md for some hints! Note that we need an electronic CLA for contributions: https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md#cla After you sign the CLA, please add your name to https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTORS.txt Also, please write a short description explaining your change in the following format: `changelog: %description%` This description will help a lot to create release changelog. Drop these lines for internal only changes :) --> Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting a milestone for merged PR even if PR was made from fork.
Previously, it didn't work for PRs from forks because of read-only permissions that Github grant to workflow with
pull_requestevent not to execute arbitrary code with write permissions in our repo. Butpull_request_targetevent allows us to have a token with write permissions even in fork PR because everything is executed in context of the base of the pull request. See more details hereContinuation of #6051.
changelog: Set milestone automatically for pull requests from forks. Previously, it worked only for pull requests in original repository