ACT: introduce Share in Playground action
#6563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undin
force-pushed
the
undin/share-in-playground-action
branch
from
6fbeb53
to
9289c21
Compare
|
Probably it's worth showing a confirmation modal window before sending the code to the server. I'm afraid someone might accidentally invoke this action, and some potentially proprietary code will immediately go to the server. In the modal window, we can also provide some information like "entire file |
|
@ortem done |
vlad20012
approved these changes
Jan 16, 2021
| @@ -286,6 +286,7 @@ project(":") { | |||
| exclude(module = "kotlin-stdlib") | |||
| } | |||
| testImplementation(project(":common", "testOutput")) | |||
| testImplementation("com.squareup.okhttp3:mockwebserver:4.9.0") | |||
artemmukhin
approved these changes
Jan 21, 2021
src/main/kotlin/org/rust/ide/actions/ShareInPlaygroundAction.kt
Outdated
Show resolved
Hide resolved
It encapsulates helper code for checking network interactions via mock web server
Undin
force-pushed
the
undin/share-in-playground-action
branch
from
636308b
to
e0f676a
Compare
|
bors r=ortem |
|
Build succeeded: |
|
Changes reflected in docs: https://plugins.jetbrains.com/plugin/8182-rust/docs/rust-quick-start.html#share-in-playground |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes:
Share in Playgroundaction to share your code in https://play.rust-lang.org/. The action correctly handles selected text in editor (i.e. share only selected text), current edition and toolchain channel.Rustaction group to have a single item in context menus for util Rust actions.Reformat File with Rustfmt,Reformat Cargo Project with Rustfmt,Rust REPL,Share in Playgroundare placed into this group as well asShow expanded Macroactions. Also, the group is added toToolsmenu.MockServerFixtureto help setting up mock web server in test to check network interactionsScreen.Recording.2020-12-28.at.02.39.43.mov
changelog: Introduce
Share in Playgroundaction to share your code in https://play.rust-lang.org/. You can invoke it viaTools | Rust | Share in Playgroundor via context menu