Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account cfg_attr during experimental compiler features annotation #6636

Merged
merged 1 commit into from Jan 12, 2021

Conversation

Undin
Copy link
Member

@Undin Undin commented Jan 8, 2021

Previously, the corresponding annotations took into account only top-level feature attributes.
Now, they correctly expand cfg_attr attribute

Continuation of #6497
Fixes #6631

changelog: Take into account cfg_attr attribute during experimental compiler features annotation

…es annotation

Previously, the corresponding annotations took into account only top-level `feature` attributes.
Now, they correctly expand `cfg_attr` attribute
@Undin Undin added the fix Pull requests that fix some bug(s) label Jan 8, 2021
@vlad20012 vlad20012 added this to In Progress in To test via automation Jan 12, 2021
@vlad20012 vlad20012 added this to the v140 milestone Jan 12, 2021
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jan 12, 2021
6636: Take into account cfg_attr during experimental compiler features annotation r=vlad20012 a=Undin

Previously, the corresponding annotations took into account only top-level `feature` attributes.
Now, they correctly expand `cfg_attr` attribute

Continuation of #6497
Fixes #6631

changelog: Take into account `cfg_attr` attribute during experimental compiler features annotation 


Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
@bors
Copy link
Contributor

bors bot commented Jan 12, 2021

Build failed:

@Undin
Copy link
Member Author

Undin commented Jan 12, 2021

bors retry

@bors
Copy link
Contributor

bors bot commented Jan 12, 2021

Build succeeded:

@bors bors bot merged commit 6bb1e5b into master Jan 12, 2021
To test automation moved this from In Progress to Test Jan 12, 2021
@bors bors bot deleted the undin/6631-compiler-feature-under-cfg branch January 12, 2021 15:01
@lancelote lancelote moved this from Test to Done in To test Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

While combining custom build script and cfg_attr, plugin can't understand enabled feature
2 participants