TY: infer type of default type parameters for known stdlib items #6643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad20012
reviewed
Jan 12, 2021
src/main/kotlin/org/rust/lang/core/types/infer/TypeInferenceWalker.kt
Outdated
Show resolved
Hide resolved
Undin
force-pushed
the
undin/fix-type-inference-for-box-and-vec
branch
from
913d363
to
33e8e62
Compare
Recent implementations of `Box` (since 1.49) and `Vec` (latest nightly) provide new allocator API. So now these items contain additional type parameter for allocator type with some default value. Previously, we didn't infer type of allocator type parameter for `box` patterns and `vec!` macro. Now it works as expected
Undin
force-pushed
the
undin/fix-type-inference-for-box-and-vec
branch
from
33e8e62
to
d9a0d6a
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent implementations of
Box(since 1.49) andVec(latest nightly) provide new allocator API.So now these items contain additional type parameter for allocator type with some default value.
Previously, we didn't infer type of allocator type parameter for
boxpatterns andvec!macro.Now it works as expected
Note, I haven't added any new test since all necessary cases are covered with existing tests. So this PR fixes some failed test with new Rust versions (see #6604)
changelog: Adjust type inference to infer type of allocator type parameter for
BoxandVecitems. See the corresponding RFC about allocator API