COMP: show all re-exports of the same item in completion #6650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved all text-based methods from `RsCompletionTestFixtureBase` to `RsCompletionTestFixture` - provide a way to pass custom renderer for `checkContainsCompletion` methods
Previously, we filter out secondary import candidates for the same item from completion suggestions, as a result, if a library (e.g. async-std) re-exports some item from another library/stdlib, completion shows only single suggestion per item. Now, we show all suggestions that can be imported - the same items as in `Auto Import` quick-fix
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we filter out secondary import candidates for the same item from completion suggestions, as a result, if a library (e.g. async-std) re-exports some item from another library/stdlib, completion shows only single suggestion per item.
Now, we show all suggestions that can be imported - the same items as in
Auto Importquick-fixFixes #5415
changelog: Show all re-exports of the same item in completion list. Previously, the plugin shows only one suggestion per item that hid alternative ways to import the item.