CARGO: improve fetching actual stdlib data #6890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undin
force-pushed
the
undin/stdlib-dependency-origin
branch
2 times, most recently
from
bf56e44
to
6c9019f
Compare
vlad20012
approved these changes
Mar 10, 2021
Undin
force-pushed
the
undin/stdlib-dependency-origin
branch
3 times, most recently
from
6cd3d48
to
965d53e
Compare
Undin
force-pushed
the
undin/stdlib-dependency-origin
branch
2 times, most recently
from
bb51918
to
00870dd
Compare
Such tests should ensure that we provide proper dependencies by `RsAdditionalLibraryRootsProvider`
As a result, dependencies tree shows stdlib dependencies as part of stdlib node instead of project dependencies
…efault It significantly slows down tests without actual necessity. Enable this feature only in some tests that actually use/check it
Undin
force-pushed
the
undin/stdlib-dependency-origin
branch
from
00870dd
to
b3db46f
Compare
|
bors r=vlad20012 |
bors bot
added a commit
that referenced
this pull request
Apr 5, 2021
6890: CARGO: improve fetching actual stdlib data r=vlad20012 a=Undin These changes: - introduce `PackageOrigin.STDLIB_DEPENDENCY` to distinguish workspace and stdlib dependencies - render stdlib dependencies as a part of stdlib and don't create separate nodes for them in `External Libraries` | Before | After | |-|-| |  |  | - add tests for project view tree - enable `org.rust.cargo.fetch.actual.stdlib.metadata` experimental feature for nightly builds Part of #6104 changelog: Don't show separate nodes for stdlib dependencies when `org.rust.cargo.fetch.actual.stdlib.metadata` experimental feature is enabled Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes:
PackageOrigin.STDLIB_DEPENDENCYto distinguish workspace and stdlib dependenciesExternal Librariesorg.rust.cargo.fetch.actual.stdlib.metadataexperimental feature for nightly buildsPart of #6104
changelog: Don't show separate nodes for stdlib dependencies when
org.rust.cargo.fetch.actual.stdlib.metadataexperimental feature is enabled