REF: Import types after Extract Function refactoring #6893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmukhin
approved these changes
Mar 16, 2021
src/test/kotlin/org/rust/ide/refactoring/RsExtractFunctionTest.kt
Outdated
Show resolved
Hide resolved
mchernyavsky
force-pushed
the
import-extract-function
branch
from
c836dec
to
04b731a
Compare
bors bot
added a commit
that referenced
this pull request
Mar 22, 2021
6893: REF: Import types after Extract Function refactoring r=ortem a=mchernyavsky <!-- Hello and thank you for the pull request! We don't have any strict rules about pull requests, but you might check https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md for some hints! Note that we need an electronic CLA for contributions: https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md#cla After you sign the CLA, please add your name to https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTORS.txt Also, please write a short description explaining your change in the following format: `changelog: %description%` This description will help a lot to create release changelog. Drop these lines for internal only changes :) --> changelog: Import unresolved types from the function signature after `Extract Function` refactoring Co-authored-by: mchernyavsky <chernyavsky.mikhail@gmail.com>
|
Build failed: |
mchernyavsky
force-pushed
the
import-extract-function
branch
from
04b731a
to
957a613
Compare
bors bot
added a commit
that referenced
this pull request
Mar 22, 2021
6893: REF: Import types after Extract Function refactoring r=ortem a=mchernyavsky <!-- Hello and thank you for the pull request! We don't have any strict rules about pull requests, but you might check https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md for some hints! Note that we need an electronic CLA for contributions: https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md#cla After you sign the CLA, please add your name to https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTORS.txt Also, please write a short description explaining your change in the following format: `changelog: %description%` This description will help a lot to create release changelog. Drop these lines for internal only changes :) --> changelog: Import unresolved types from the function signature after `Extract Function` refactoring Co-authored-by: mchernyavsky <chernyavsky.mikhail@gmail.com>
|
Build failed: |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Import unresolved types from the function signature after
Extract Functionrefactoring