Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Omit unchanged default type parameters of return type in ExtractFunction #6897

Merged
merged 1 commit into from Feb 28, 2021

Conversation

mchernyavsky
Copy link
Member

@mchernyavsky mchernyavsky commented Feb 26, 2021

changelog: Omit unchanged default type parameters of return type in Extract Function refactoring

@mchernyavsky mchernyavsky added the fix Pull requests that fix some bug(s) label Feb 26, 2021
Copy link
Member Author

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r=Kobzol

bors bot added a commit that referenced this pull request Feb 27, 2021
6897: REF: Omit unchanged default type parameters of return type in ExtractFunction r=Kobzol a=mchernyavsky

<!--
Hello and thank you for the pull request!

We don't have any strict rules about pull requests, but you might check
https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md
for some hints!

Note that we need an electronic CLA for contributions:
https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTING.md#cla

After you sign the CLA, please add your name to
https://github.com/intellij-rust/intellij-rust/blob/master/CONTRIBUTORS.txt

Also, please write a short description explaining your change in the following format: `changelog: %description%`
This description will help a lot to create release changelog. 
Drop these lines for internal only changes

:)
-->

changelog: Omit unchanged default type parameters of return type in `Extract Function` refactoring


Co-authored-by: mchernyavsky <chernyavsky.mikhail@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 27, 2021

Build failed:

@mchernyavsky
Copy link
Member Author

bors retry

@bors
Copy link
Contributor

bors bot commented Feb 28, 2021

Build succeeded:

@bors bors bot merged commit 9e9a3ee into master Feb 28, 2021
@bors bors bot deleted the fix-implement-memers-ret-type branch February 28, 2021 13:07
@github-actions github-actions bot added this to the v143 milestone Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants