New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBG: debugger support for Rider for Unreal Engine 2021.1 #6907
Conversation
…rter For some reason, Rider debugging integration fails when the platform calls `XDebugProcessConfiguratorStarter#configure`. But since we don't configure anything, let's drop it
Rider 4UE has bundled LLDB binaries so it makes no sense to download them. It keeps the binaries inside Native Debugging Support plugin directory so these changes adjust `RsDebuggerToolchainService#getLLDBStatus` to check binaries inside plugin directory first
Important places for testing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Works fine on my machine, without extra downloads and settings
val runParameters = RsDebugRunParameters(environment.project, runExecutable, state.cargoProject) | ||
return XDebuggerManager.getInstance(environment.project) | ||
.startSession(environment, object : XDebugProcessConfiguratorStarter() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, Rider debugging integration fails when the platform calls
XDebugProcessConfiguratorStarter#configure
Sounds strange to me, I hope XDebugProcessStarter
really solves this and there are no other unexpected problems
bors r=ortem |
Build succeeded: |
8265: DBG: second attempt to support debugging in Rider for Unreal Engine r=ortem a=Undin Part of #5422 Previous attempt: #6907 Fixes #7201 After #6907, Rider for Unreal Engine has changed the inner structure of plugins related to native debugging. Previously, it contained bundled [Native Debugging Support](https://plugins.jetbrains.com/plugin/12775-native-debugging-support) plugin with bundled debugger binaries. Now, it contains the same plugin `com.intellij.cidr.debugger` as CLion (that's why it didn't work with initial implementation), so we don't need to invent a way how to determine if IDE contains bundled debugger binaries and we can just use `LLDBDriverConfiguration.hasBundledLLDB()` Current restrictions: - only [Rider for Unreal Engine](https://www.jetbrains.com/lp/rider-unreal/) is supported for now - only LLDB changelog: Provide debugging in [Rider for Unreal Engine](https://www.jetbrains.com/lp/rider-unreal/). Note, previously there was an attempt to support the debugging in Rider for Unreal Engine but it didn't work because of some technical reasons Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
Current restrictions:
Part of #5422
changelog: Provide debugging in Rider for Unreal Engine 2021.1