Reduce availability range of some intentions #6923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `AddElseIntention` now is not available inside `if` body - `InvertIfIntention` is now available only in `if` keyword - `IfLetToMatchIntention` is now available only in `if let` keywords and `=` token - `MatchToIfLetIntention` is now available only in `match` keyword - `SplitIfIntention` is now available only in a binary operator (like `&&`) - `FlipBinaryExpressionIntention` is now available only in a binary operator (like `&&`) - `ExtractInlineModuleIntention` is now available only in `mod` keyword, a module name and its visibility (not available in a module body or its attributes) - `RsShowMacroExpansionIntentionBase` is now available only in a macro call path and `!` token
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce availability range of some intentions:
AddElseIntentionnow is not available insideifbodyInvertIfIntentionis now available only inifkeywordIfLetToMatchIntentionis now available only inif letkeywords and=tokenMatchToIfLetIntentionis now available only inmatchkeywordSplitIfIntentionis now available only in a binary operator (like&&)FlipBinaryExpressionIntentionis now available only in a binary operator (like&&)ExtractInlineModuleIntentionis now available only inmodkeyword, a module name and its visibility (not available in a module body or its attributes)RsShowMacroExpansionIntentionBaseis now available only in a macro call path and!tokenThis mostly follows availability ranges of Kotlin's intentions
changelog: Reduce availability range of some intention actions. For example, now "Add else branch to this if statement" should not be suggested in
Alt+Entermenu when the caret is placed inside anifbody