Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase minimal supported rustc version to 1.41.0 #6956

Merged
merged 7 commits into from Mar 19, 2021
Merged

Increase minimal supported rustc version to 1.41.0 #6956

merged 7 commits into from Mar 19, 2021

Conversation

Undin
Copy link
Member

@Undin Undin commented Mar 13, 2021

And drop all (or almost all) code for rustic below 1.41

changelog: Increase minimal supported rustc version to 1.41.0

@Undin Undin added the feature label Mar 13, 2021
@Undin Undin force-pushed the undin/min-rustc-version branch 2 times, most recently from 4e802e7 to 6a2bcba Compare March 13, 2021 19:30
vlad20012
vlad20012 approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@vlad20012 vlad20012 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also bump RsToolchain.MIN_SUPPORTED_TOOLCHAIN to 1.41.0

artemmukhin
artemmukhin approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@artemmukhin artemmukhin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in pretty-printers look fine to me

@Undin
Copy link
Member Author

Undin commented Mar 19, 2021

bors r=vlad20012

@bors
Copy link
Contributor

bors bot commented Mar 19, 2021

Build succeeded:

@bors bors bot merged commit 52fe8c4 into master Mar 19, 2021
@bors bors bot deleted the undin/min-rustc-version branch March 19, 2021 14:54
@github-actions github-actions bot added this to the v144 milestone Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad20012 vlad20012 vlad20012 approved these changes

@artemmukhin artemmukhin artemmukhin approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v144
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Undin @vlad20012 @artemmukhin