Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QDOC: properly render const generics in signature of top-level items #6958

Merged
merged 1 commit into from Mar 14, 2021
Merged

QDOC: properly render const generics in signature of top-level items #6958

merged 1 commit into from Mar 14, 2021

Conversation

Undin
Copy link
Member

@Undin Undin commented Mar 13, 2021

Before After

Part of #3985

changelog: Properly render const generics in signature of top-level items

@Undin Undin added the fix Pull requests that fix some bug(s) label Mar 13, 2021
@Undin Undin mentioned this pull request Mar 13, 2021
Open
32 tasks
mchernyavsky
mchernyavsky approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Mar 14, 2021
@bors @Undin
Merge #6958
0eb032d 
6958: QDOC: properly render const generics in signature of top-level items r=mchernyavsky a=Undin

| Before | After |
| - | - |
| ![](https://user-images.githubusercontent.com/2539310/111044077-72eba880-8457-11eb-840d-7496723212a2.png) | ![](https://user-images.githubusercontent.com/2539310/111044079-77b05c80-8457-11eb-9f3c-d5d18d6486fb.png) |

Part of #3985

changelog: Properly render const generics in signature of top-level items


Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
@bors
Copy link
Contributor

bors bot commented Mar 14, 2021

Build failed:

@Undin
Copy link
Member Author

Undin commented Mar 14, 2021

bors retry

@bors
Copy link
Contributor

bors bot commented Mar 14, 2021

Build succeeded:

@bors bors bot merged commit 17a64c5 into master Mar 14, 2021
@bors bors bot deleted the undin/render-const-generic-in-signatures branch March 14, 2021 19:34
@github-actions github-actions bot added this to the v144 milestone Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchernyavsky mchernyavsky mchernyavsky approved these changes

Assignees

@mchernyavsky mchernyavsky

Labels
fix Pull requests that fix some bug(s)
Projects
None yet
Milestone
v144
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Undin @mchernyavsky