Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRAM: improve parser recovery in function arguments #7019

Merged
merged 1 commit into from Mar 31, 2021
Merged

GRAM: improve parser recovery in function arguments #7019

merged 1 commit into from Mar 31, 2021

Conversation

vlad20012
Copy link
Member

Better parser recovery on missed function arguments. Works in cases like:

foo(1, , 2);
foo(,, 2);
foo(1,,);

changelog: Improve parser recovery in function arguments

@vlad20012 vlad20012 added the fix Pull requests that fix some bug(s) label Mar 25, 2021
@vlad20012 vlad20012 mentioned this pull request Mar 25, 2021
Closed
@Kobzol Kobzol mentioned this pull request Mar 25, 2021
Merged
@vlad20012 vlad20012 force-pushed the gram-improve-function-arguments-recovery branch 2 times, most recently from ef6985f to ff501ef Compare March 25, 2021 15:23
@vlad20012
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 25, 2021
@bors
Try #7019:
a377241
@bors
Copy link
Contributor

bors bot commented Mar 25, 2021

try

Build failed:

@vlad20012 vlad20012 force-pushed the gram-improve-function-arguments-recovery branch from ff501ef to 00579b3 Compare March 26, 2021 08:44
@vlad20012 vlad20012 force-pushed the gram-improve-function-arguments-recovery branch from 00579b3 to f16dffc Compare March 30, 2021 16:39
@vlad20012
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 31, 2021

Build succeeded:

@bors bors bot merged commit 980baa2 into master Mar 31, 2021
@bors bors bot deleted the gram-improve-function-arguments-recovery branch March 31, 2021 09:55
@github-actions github-actions bot added this to the v145 milestone Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@artemmukhin artemmukhin

Labels
fix Pull requests that fix some bug(s)
Projects
None yet
Milestone
v145
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vlad20012 @artemmukhin