Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Convert to type quick-fixes #7026

Merged
merged 3 commits into from Mar 26, 2021

Conversation

Undin
Copy link
Member

@Undin Undin commented Mar 26, 2021

These changes:

  • refactor Convert to type quick-fixes. All common code is extracted into a single place, new base ConvertToTyFix class.
    Also, now you can only pass RsExpr to the corresponding quick-fixes instead of any psi object
  • omit default type parameters in a quick-fix text

changelog: Omit default type parameters in a Convert to type quick-fix text

Introduce `ConvertToTyFix` as base class for all similar quick fixes and make other `Convert to type` quick-fixes a children classes
@Undin Undin added the fix Pull requests that fix some bug(s) label Mar 26, 2021
@Undin
Copy link
Member Author

Undin commented Mar 26, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 26, 2021

Build succeeded:

@bors bors bot merged commit 72ff067 into master Mar 26, 2021
@bors bors bot deleted the undin/improve-convert-to-type-quick-fixes branch March 26, 2021 21:57
@github-actions github-actions bot added this to the v145 milestone Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant