TOML: ignore path references with wildcards to avoid false positives #7403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undin
requested changes
Jun 25, 2021
toml/src/main/kotlin/org/rust/toml/resolve/CargoTomlFileReferenceProvider.kt
Outdated
Show resolved
Hide resolved
Kobzol
force-pushed
the
toml-ignore-wildcard-in-path
branch
from
ae67ea0
to
3f36339
Compare
|
I see. I changed it so that any references after and including the first glob reference are ignored inside workspace |
Undin
requested changes
Jun 26, 2021
There was a problem hiding this comment.
I see. I changed it so that any references after and including the first glob reference are ignored inside workspace members.
I'm not sure how to use thecreateRegexfunction though, it didn't seem to create a regex that would recognize a glob pattern.
Sorry for the confusion. I meant that createRegex can be used as an example of parsing implementation if we need it. But parsing reduced to several contains
toml/src/main/kotlin/org/rust/toml/resolve/CargoTomlFileReferenceProvider.kt
Outdated
Show resolved
Hide resolved
toml/src/main/kotlin/org/rust/toml/resolve/CargoTomlFileReferenceProvider.kt
Outdated
Show resolved
Hide resolved
toml/src/main/kotlin/org/rust/toml/resolve/CargoTomlFileReferenceProvider.kt
Outdated
Show resolved
Hide resolved
toml/src/main/kotlin/org/rust/toml/resolve/CargoTomlFileReferenceProvider.kt
Outdated
Show resolved
Hide resolved
toml/src/main/kotlin/org/rust/toml/resolve/CargoTomlFileReferenceProvider.kt
Show resolved
Hide resolved
Undin
reviewed
Jul 5, 2021
toml/src/main/kotlin/org/rust/toml/resolve/CargoTomlFileReferenceProvider.kt
Outdated
Show resolved
Hide resolved
Kobzol
force-pushed
the
toml-ignore-wildcard-in-path
branch
2 times, most recently
from
3e0733f
to
4d14600
Compare
Kobzol
force-pushed
the
toml-ignore-wildcard-in-path
branch
from
4d14600
to
98d17c8
Compare
bors bot
added a commit
that referenced
this pull request
Jul 7, 2021
7403: TOML: ignore path references with wildcards to avoid false positives r=Undin a=Kobzol Fixes: #7402 changelog: Ignore paths with wildcards in TOML to avoid false positives. 7427: Reset crates local index state if index is empty r=Undin a=avrong Reset the last commit hash of the index if the index PersistentHashMap size is 0. This will fix the issues when the index file has been deleted or did not move with the state, e.g. when the latest IDE release copied the state without index map 7449: REF: Handle root modules in "Promote module to directory" refactoring r=ortem a=dima74 Fixes #7041 changelog: Correctly handle root modules in "Promote module to directory" refactoring Co-authored-by: Jakub Beránek <berykubik@gmail.com> Co-authored-by: Aleksei Trifonov <avrong@avrong.me> Co-authored-by: Dmitry Murzin <diralik@yandex.ru>
|
This PR was included in a batch that timed out, it will be automatically retried |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7402
changelog: Ignore paths with wildcards in TOML to avoid false positives.