Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TY&RES: support const arguments that looks like type arguments #7479

Merged
merged 2 commits into from Jul 23, 2021
Merged

TY&RES: support const arguments that looks like type arguments #7479

merged 2 commits into from Jul 23, 2021

Conversation

vlad20012
Copy link
Member

@vlad20012 vlad20012 commented Jul 7, 2021 •
edited

Related to #3985, fixes (partially, except Extra error case) #7420

@vlad20012 vlad20012 force-pushed the const-generic-disambiguation-2 branch 2 times, most recently from da4b145 to 760f66f Compare July 7, 2021 16:07
@vlad20012 vlad20012 mentioned this pull request Jul 8, 2021
Merged
@vlad20012 vlad20012 force-pushed the const-generic-disambiguation-2 branch 2 times, most recently from 49e607b to 48f4b58 Compare July 9, 2021 04:53
@vlad20012 vlad20012 force-pushed the const-generic-disambiguation-2 branch 4 times, most recently from ad2f76e to 282b515 Compare July 19, 2021 13:41
@vlad20012 vlad20012 force-pushed the const-generic-disambiguation-2 branch from 282b515 to a891b69 Compare July 19, 2021 17:07
@Kobzol Kobzol mentioned this pull request Jul 20, 2021
Merged
@vlad20012 vlad20012 marked this pull request as ready for review July 20, 2021 12:48
mchernyavsky
mchernyavsky approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@mchernyavsky
Copy link
Member

TODO: Fix RsPath.typeArguments, RsPath.constArguments, RsMethodCall.typeArguments RsMethodCall.constArguments and corresponding inspections

@bors
Copy link
Contributor

bors bot commented Jul 23, 2021

Build succeeded:

@bors bors bot merged commit c5d9bbe into master Jul 23, 2021
@bors bors bot deleted the const-generic-disambiguation-2 branch July 23, 2021 12:36
@github-actions github-actions bot added this to the v152 milestone Jul 23, 2021
@vlad20012 vlad20012 mentioned this pull request Dec 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

@mchernyavsky mchernyavsky mchernyavsky approved these changes

Assignees

@mchernyavsky mchernyavsky

Labels
feature
Projects
None yet
Milestone
v152
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vlad20012 @mchernyavsky @Kobzol