Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MISC): Recursive calls gutter marker #758

Merged
merged 4 commits into from
Oct 24, 2016

Conversation

alygin
Copy link
Member

@alygin alygin commented Oct 22, 2016

This is #756. Just reopened because of failed checks due to github temporary inaccessibility.

An annotator that detects and marks recursive calls:

screen shot 2016-10-22 at 08 25 03

Works for pure functions, associated functions and methods.

@matklad
Copy link
Member

matklad commented Oct 24, 2016

This is #756. Just reopened because of failed checks due to github temporary inaccessibility.

I think you can just close and reopen the same pull request. Let me check.

@matklad matklad closed this Oct 24, 2016
@matklad matklad reopened this Oct 24, 2016
@matklad
Copy link
Member

matklad commented Oct 24, 2016

Yep, this restarts the CI.

@mkaput
Copy link
Member

mkaput commented Oct 24, 2016

I believe travis has option to restart build directly from it's ui

This doesn't apply to PRs though 😞

@matklad
Copy link
Member

matklad commented Oct 24, 2016

I believe travis has option to restart build directly from it's ui

😅 I swear there weren't this button in the UI for pull requests the last time i've checked, but there is one now! Thanks!

@matklad
Copy link
Member

matklad commented Oct 24, 2016

This doesn't apply to PRs though

It does:

pr

@alygin
Copy link
Member Author

alygin commented Oct 24, 2016

I believe this button has always been there if one has enough repository permissions.

@alygin
Copy link
Member Author

alygin commented Oct 24, 2016

Regarding the broken build for the LATEST_EAP, I'll have a look at it a bit later. There's a flag Pass.UPDATE_OVERRIDEN_MARKERS that was deprecated and the new one, Pass.UPDATE_OVERRIDDEN_MARKERS introduced. But it seems the latest EAP supports none of these.

@matklad matklad merged commit 9cd0254 into intellij-rust:master Oct 24, 2016
@matklad
Copy link
Member

matklad commented Oct 24, 2016

Thanks!

@matklad
Copy link
Member

matklad commented Oct 24, 2016

BTW, trait navigation icons are in today's alpha: https://intellij-rust.github.io/2016/10/24/changelog-16.html :)

@alygin
Copy link
Member Author

alygin commented Oct 24, 2016

Cool! I hope it will come in handy.

@alygin alygin deleted the mark-recursive-call branch October 24, 2016 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants