Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRAM&ANN: parse unsafe keyword in extern block and annotate it as error #7769

Merged
merged 2 commits into from Sep 1, 2021

Conversation

Undin
Copy link
Member

@Undin Undin commented Sep 1, 2021

Closes #7767

Similar to #7751

changelog: Parse unsafe keyword in extern block and provide error annotation for it

Note, `unsafe` is semantically invalid in case of extern block item. The corresponding change is made to improve error message.
See the corresponding change in rustc: rust-lang/rust#75857
@Undin Undin added the feature label Sep 1, 2021
@Undin Undin added this to In Progress in To test via automation Sep 1, 2021
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 1, 2021

Build succeeded:

@bors bors bot merged commit 158a66e into master Sep 1, 2021
To test automation moved this from In Progress to Test Sep 1, 2021
@bors bors bot deleted the undin/7767-unsafe-extern-block branch September 1, 2021 13:09
@github-actions github-actions bot added this to the v155 milestone Sep 1, 2021
@mili-l mili-l moved this from Test to Done in To test Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

Parse unsafe keyword in extern block and annotate it as error
2 participants