Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUN: Fix Coverage runner for projects located on WSL file system #7906

Merged
merged 4 commits into from Dec 17, 2021

Conversation

mchernyavsky
Copy link
Member

Fixes #7896.

changelog: Fix Run with Coverage for projects located on WSL file system

@mchernyavsky mchernyavsky added the fix Pull requests that fix some bug(s) label Sep 28, 2021
@Undin Undin added this to In Progress in To test via automation Sep 28, 2021
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with WSL toolchain with project in WSL filesystem and with Windows filesystem
But it doesn't work with local filesystem and local toolchain on Windows
But looks like it doesn't work with stable plugin as well

@mchernyavsky mchernyavsky changed the title RUB: Fix Coverage runner for projects located on WSL file system RUN: Fix Coverage runner for projects located on WSL file system Oct 12, 2021
Copy link
Member

@Undin Undin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

src/main/kotlin/org/rust/cargo/toolchain/tools/Cargo.kt Outdated Show resolved Hide resolved
@mchernyavsky mchernyavsky force-pushed the fix-wsl-coverage branch 2 times, most recently from 3585a2c to 001902b Compare December 17, 2021 19:59
Copy link
Member Author

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r=Undin

bors bot added a commit that referenced this pull request Dec 17, 2021
7906: RUN: Fix Coverage runner for projects located on WSL file system r=Undin a=mchernyavsky

Fixes #7896.

changelog: Fix `Run with Coverage` for projects located on WSL file system


Co-authored-by: mchernyavsky <chernyavsky.mikhail@gmail.com>
Co-authored-by: mhernyavsky <chernyavsky.mikhail@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 17, 2021

Canceled.

@mchernyavsky
Copy link
Member Author

bors r=Undin

bors bot added a commit that referenced this pull request Dec 17, 2021
7906: RUN: Fix Coverage runner for projects located on WSL file system r=Undin a=mchernyavsky

Fixes #7896.

changelog: Fix `Run with Coverage` for projects located on WSL file system


Co-authored-by: mchernyavsky <chernyavsky.mikhail@gmail.com>
Co-authored-by: mhernyavsky <chernyavsky.mikhail@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 17, 2021

Canceled.

@mchernyavsky
Copy link
Member Author

bors r=Undin

@bors
Copy link
Contributor

bors bot commented Dec 17, 2021

Build succeeded:

@bors bors bot merged commit 824fda7 into master Dec 17, 2021
To test automation moved this from In Progress to Test Dec 17, 2021
@bors bors bot deleted the fix-wsl-coverage branch December 17, 2021 22:07
@github-actions github-actions bot added this to the v163 milestone Dec 17, 2021
@mili-l mili-l self-assigned this Dec 20, 2021
@mili-l mili-l moved this from Test to Done in To test Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

Coverage is not working on a wsl system.
3 participants