REF: fix extract variable on RsExprStmt and last expr in block #8100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima74
reviewed
Nov 12, 2021
src/test/kotlin/org/rust/ide/intentions/IntroduceLocalVariableIntentionTest.kt
Show resolved
Hide resolved
This involves a change to the tests. The old behaviour was breaking code since it changed the returned value of the block from T to (), and breaking code is bad. It's also trivially easy to change the returned value after refactoring to a more complex expression, since only a single identifier should be returned. This commit also includes a fix for extracting several occurrences of an expression. Previously if we extracted an RsExprStmt, then the logic would short-circuit and extract only it, ignoring the possibility of other occurrences.
dima74
reviewed
Nov 16, 2021
src/test/kotlin/org/rust/ide/refactoring/RsIntroduceVariableHandlerTest.kt
Show resolved
Hide resolved
|
👍 |
|
Build succeeded: |
This was referenced Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involves a change to the tests. The old behaviour was breaking code since it changed the returned value of the block from T to (), and breaking code is bad. It's also trivially easy to change the returned value after refactoring to a more complex expression, since only a single identifier should be returned.
This commit also includes a fix for extracting several occurrences of an expression. Previously if we extracted an RsExprStmt, then the logic would short-circuit and extract only it, ignoring the possibility of other occurrences.
Fixes #8099
Fixes #8095
Fixes #8082
Fixes #8091
changelog: fix "Extract variable" refactoring on expression statements and return values