Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto import: use absolute path for extern crate if needed #8112

Merged
merged 1 commit into from Nov 22, 2021

Conversation

dima74
Copy link
Member

@dima74 dima74 commented Nov 16, 2021

Fixes #7394

changelog: Use absolute import path in auto-import when the scope has child mod with the same name as extern crate

@dima74 dima74 added the fix Pull requests that fix some bug(s) label Nov 16, 2021
@dima74 dima74 added this to In Progress in To test via automation Nov 16, 2021
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Nov 22, 2021
8052: INSP: Support usages in attr proc macros in unused imports inspection r=vlad20012 a=dima74

For now, usages are searched in the current mod only

Meta issue: #2158

changelog: Support usages in attribute proc macros in unused imports inspection

8054: INSP: New auto-import for UFCS trait methods r=vlad20012 a=dima74

Continuation of #8029 for auto-import traits for UFCS.
Meta issue: #7558

changelog: Improve traits auto-import for [UFCS](https://doc.rust-lang.org/1.7.0/book/ufcs.html) methods

8112: Auto import: use absolute path for extern crate if needed r=vlad20012 a=dima74

Fixes #7394

changelog: Use absolute import path in auto-import when the scope has child mod with the same name as extern crate


8135: RES: Fix updating DefMap when adding `#![no_std]` r=vlad20012 a=dima74

changelog: Fixes caching of resolve when adding or removing `#![no_std]` attribute


Co-authored-by: Dmitry Murzin <diralik@yandex.ru>
@bors
Copy link
Contributor

bors bot commented Nov 22, 2021

This PR was included in a batch that timed out, it will be automatically retried

@bors
Copy link
Contributor

bors bot commented Nov 22, 2021

Build succeeded:

@bors bors bot merged commit 35be65c into master Nov 22, 2021
To test automation moved this from In Progress to Test Nov 22, 2021
@bors bors bot deleted the diralik/auto-import-extern-crate-absolute-path branch November 22, 2021 23:36
@github-actions github-actions bot added this to the v161 milestone Nov 22, 2021
@neonaot neonaot self-assigned this Nov 25, 2021
@neonaot neonaot moved this from Test to Done in To test Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

Cannot handle auto-import when crate name has the same name as module name
4 participants