Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RES: Fix resolve of macros inside functions using new resolve #8398

Merged
merged 1 commit into from Jan 14, 2022
Merged

RES: Fix resolve of macros inside functions using new resolve #8398

merged 1 commit into from Jan 14, 2022

Conversation

dima74
Copy link
Member

@dima74 dima74 commented Jan 12, 2022

Fixes #8394

changelog: Fix expansion of pin_project_lite::pin_project macro inside function bodies

@dima74 dima74 added the fix Pull requests that fix some bug(s) label Jan 12, 2022
@dima74 dima74 added this to In Progress in To test via automation Jan 12, 2022
vlad20012
vlad20012 approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jan 13, 2022
@bors @dima74
Merge #8398
b015681 
8398: RES: Fix resolve of macros inside functions using new resolve r=vlad20012 a=dima74

Fixes #8394

changelog: Fix expansion of `pin_project_lite::pin_project` macro inside function bodies


Co-authored-by: Dmitry Murzin <diralik@yandex.ru>
@vlad20012
Copy link
Member

bors r-

@bors
Copy link
Contributor

bors bot commented Jan 13, 2022

Canceled.

@dima74 dima74 force-pushed the diralik/resolve2-fix-$crate-inside-functions branch from 64b1bc2 to a457fb5 Compare January 14, 2022 09:36
@dima74 dima74 requested a review from vlad20012 January 14, 2022 12:04
vlad20012
vlad20012 approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@vlad20012 vlad20012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
bors r+

@bors
Copy link
Contributor

bors bot commented Jan 14, 2022

Build succeeded:

@bors bors bot merged commit 74e9f01 into master Jan 14, 2022
To test automation moved this from In Progress to Test Jan 14, 2022
@bors bors bot deleted the diralik/resolve2-fix-$crate-inside-functions branch January 14, 2022 16:20
@github-actions github-actions bot added this to the v164 milestone Jan 14, 2022
@mili-l mili-l self-assigned this Jan 19, 2022
@mili-l mili-l moved this from Test to Done in To test Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad20012 vlad20012 vlad20012 approved these changes

Assignees

@mili-l mili-l

@vlad20012 vlad20012

Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v164
Development

Successfully merging this pull request may close these issues.

pin_project_lite::pin_project is not expanded inside function body
3 participants
@dima74 @vlad20012 @mili-l