Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RES: fix primitive vs mod #8401

Merged
merged 1 commit into from Jan 14, 2022
Merged

RES: fix primitive vs mod #8401

merged 1 commit into from Jan 14, 2022

Conversation

vlad20012
Copy link
Member

Previously, str::trim was unresolved in this example:

mod str {
    pub fn foo() {}
}

fn main () {
    str::foo();
    str::trim("123");
}

image

Now it is resolved to a method in impl for str. str segment in str::trim path is still resolved to mod str, unfortunately :(

@vlad20012 vlad20012 added the fix Pull requests that fix some bug(s) label Jan 13, 2022
@vlad20012 vlad20012 added this to In Progress in To test via automation Jan 13, 2022
@dima74
Copy link
Member

dima74 commented Jan 14, 2022

bors r+

bors bot added a commit that referenced this pull request Jan 14, 2022
@bors @vlad20012
Merge #8401
f857407 
8401: RES: fix primitive vs mod r=dima74 a=vlad20012

Previously, `str::trim` was unresolved in this example:
```rust
mod str {
    pub fn foo() {}
}

fn main () {
    str::foo();
    str::trim("123");
}
```

![image](https://user-images.githubusercontent.com/3221931/149309113-ac22d774-96ea-4905-94bb-55ef7def772c.png)

Now it is resolved to a method in impl for `str`. `str` segment in `str::trim` path is still resolved to `mod str`, unfortunately :(

Co-authored-by: vlad20012 <beskvlad@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 14, 2022

Build failed:

@vlad20012
Copy link
Member Author

bors retry

@bors
Copy link
Contributor

bors bot commented Jan 14, 2022

Build succeeded:

  • check

@bors bors bot merged commit 0ed6034 into master Jan 14, 2022
To test automation moved this from In Progress to Test Jan 14, 2022
@bors bors bot deleted the fix-primitive-vs-mod branch January 14, 2022 18:47
@github-actions github-actions bot added this to the v164 milestone Jan 14, 2022
@neonaot neonaot self-assigned this Jan 17, 2022
@neonaot neonaot moved this from Test to Done in To test Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dima74 dima74 dima74 approved these changes

Assignees

@dima74 dima74

@neonaot neonaot

Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v164
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vlad20012 @dima74 @neonaot