Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TY: infer type of &raw const and &raw mut operators #8410

Merged
merged 1 commit into from Jan 17, 2022

Conversation

Undin
Copy link
Member

@Undin Undin commented Jan 14, 2022

As a result, the plugin now knows the proper type of addr_of! and addr_of_mut! macro calls from stdlib

Fixes #8405

changelog: Infer type of &raw const and &raw mut operators. As a result, the plugin now knows the proper type of addr_of! and addr_of_mut! macro calls from stdlib

@Undin Undin added the feature label Jan 14, 2022
@Undin Undin added this to In Progress in To test via automation Jan 14, 2022
As a result, the plugin now knows the proper type of `addr_of!` and `addr_of_mut!` macro calls from stdlib
@Undin Undin force-pushed the undin/8405-infer-&raw-expr-type branch from 61d3c61 to 1c443bc Compare January 14, 2022 15:06
Copy link
Member

@mchernyavsky mchernyavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 17, 2022

Build succeeded:

@bors bors bot merged commit 5d1ab05 into master Jan 17, 2022
To test automation moved this from In Progress to Test Jan 17, 2022
@bors bors bot deleted the undin/8405-infer-&raw-expr-type branch January 17, 2022 17:17
@github-actions github-actions bot added this to the v164 milestone Jan 17, 2022
@LoganDark
Copy link

Really inconvenient that this missed the 163 release by just 4 hours - gonna have to build from source. Ty though!

@mchernyavsky
Copy link
Member

Really inconvenient that this missed the 163 release by just 4 hours - gonna have to build from source. Ty though!

@LoganDark Actually, a release branch is created from master a week before a release itself (for testers).

Note: you can install the nightly version of the plugin without building from source - link.

@LoganDark
Copy link

LoganDark commented Jan 18, 2022

Note: you can install the nightly version of the plugin without building from source - link.

Oh, that's useful - my source-built version of the plugin is having some major workflow-breaking issues:
image

Absolutely can't be used in this state - it's ridiculous. I'll try the nightly builds

Edit: Nightly build doesn't yet include this pull request D::. Will have to try tomorrow then. Doesn't have the horrible type checking issues though!

@mili-l mili-l self-assigned this Jan 21, 2022
@mili-l mili-l moved this from Test to Done in To test Jan 25, 2022
@afetisov afetisov mentioned this pull request May 2, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

Support std::ptr::addr_of! and std::ptr::addr_of_mut!
4 participants