Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANN: escape module name if needed in Attach to module quick-fix #8447

Merged
merged 1 commit into from Jan 21, 2022
Merged

ANN: escape module name if needed in Attach to module quick-fix #8447

merged 1 commit into from Jan 21, 2022

Conversation

Undin
Copy link
Member

@Undin Undin commented Jan 21, 2022

Fixes #8445

changelog: Properly add new module declaration by Attach file to module quick-fix if a new module has a keyword-like name

Kobzol
Kobzol approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally.

@Undin Undin added the fix Pull requests that fix some bug(s) label Jan 21, 2022
@Undin Undin added this to In Progress in To test via automation Jan 21, 2022
@Undin
Copy link
Member Author

Undin commented Jan 21, 2022

bors r=Kobzol

@bors
Copy link
Contributor

bors bot commented Jan 21, 2022

Build succeeded:

@bors bors bot merged commit bcafe97 into master Jan 21, 2022
To test automation moved this from In Progress to Test Jan 21, 2022
@bors bors bot deleted the undin/8445-improve-attach-module-fix branch January 21, 2022 18:09
@github-actions github-actions bot added this to the v164 milestone Jan 21, 2022
@mili-l mili-l self-assigned this Jan 25, 2022
@mili-l mili-l moved this from Test to Done in To test Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol approved these changes

Assignees

@mili-l mili-l

@Kobzol Kobzol

Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v164
Development

Successfully merging this pull request may close these issues.

Attach file to module fails with keyword-like names
3 participants
@Undin @Kobzol @mili-l