Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6411: Provide context features and more element features for ML-completion #8515

Merged
merged 2 commits into from Feb 7, 2022

Conversation

vlad20012
Copy link
Member

@vlad20012 vlad20012 commented Feb 5, 2022

Related to #6411

New element features:

  • IS_OPERATOR_METHOD
  • IS_BLANKET_IMPL_MEMBER
  • IS_UNSAFE_FN
  • IS_ASYNC_FN
  • IS_CONST_FN_OR_CONST
  • IS_EXTERN_FN

New context features:

  • IS_UNSAFE_CONTEXT
  • IS_ASYNC_CONTEXT
  • IS_CONST_CONTEXT

@vlad20012 vlad20012 added this to the v165 milestone Feb 7, 2022
Copy link
Member

@artemmukhin artemmukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vlad20012 vlad20012 force-pushed the provide-more-ml-completion-element-features branch from 7cf3fcb to fd9a0c0 Compare February 7, 2022 14:05
- IS_OPERATOR_METHOD
- IS_BLANKET_IMPL_MEMBER
- IS_UNSAFE_FN
- IS_ASYNC_FN
- IS_CONST_FN_OR_CONST
- IS_EXTERN_FN
@vlad20012 vlad20012 force-pushed the provide-more-ml-completion-element-features branch 2 times, most recently from a0c17da to a1d7bb8 Compare February 7, 2022 17:10
- IS_UNSAFE_CONTEXT
- IS_ASYNC_CONTEXT
- IS_CONST_CONTEXT
@vlad20012 vlad20012 force-pushed the provide-more-ml-completion-element-features branch from a1d7bb8 to e2d9c81 Compare February 7, 2022 17:10
@vlad20012
Copy link
Member Author

bors r=ortem

@vlad20012 vlad20012 added this to In Progress in To test via automation Feb 7, 2022
@bors
Copy link
Contributor

bors bot commented Feb 7, 2022

Build succeeded:

@bors bors bot merged commit d00fbd6 into master Feb 7, 2022
To test automation moved this from In Progress to Test Feb 7, 2022
@bors bors bot deleted the provide-more-ml-completion-element-features branch February 7, 2022 18:19
@Undin Undin added internal Pull requests about internal improvements/fixes that don't affect users directly and removed feature labels Feb 8, 2022
@neonaot neonaot self-assigned this Feb 10, 2022
@neonaot neonaot moved this from Test to Done in To test Feb 10, 2022
artemmukhin added a commit that referenced this pull request Apr 5, 2022
This enables the new features added in #8515 with 2021.3 builds. Originally, these new features were enabled only with 2022.1 builds to work with a previous ML ranking model. Now, since the model is updated to version 0.4.1, they can be used with any build.
artemmukhin added a commit that referenced this pull request Apr 8, 2022
This enables the new features added in #8515 with 2021.3 builds. Originally, these new features were enabled only with 2022.1 builds to work with a previous ML ranking model. Now, since the model is updated to version 0.4.1, they can be used with any build.
yopox pushed a commit to Kobzol/intellij-rust that referenced this pull request Feb 27, 2023
This enables the new features added in intellij-rust#8515 with 2021.3 builds. Originally, these new features were enabled only with 2022.1 builds to work with a previous ML ranking model. Now, since the model is updated to version 0.4.1, they can be used with any build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Pull requests about internal improvements/fixes that don't affect users directly
Projects
To test
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants