New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6411: Provide context features and more element features for ML-completion #8515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmukhin
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ml-completion/src/main/kotlin/org/rust/ml/RsElementFeatureProvider.kt
Outdated
Show resolved
Hide resolved
vlad20012
force-pushed
the
provide-more-ml-completion-element-features
branch
from
February 7, 2022 14:05
7cf3fcb
to
fd9a0c0
Compare
- IS_OPERATOR_METHOD - IS_BLANKET_IMPL_MEMBER - IS_UNSAFE_FN - IS_ASYNC_FN - IS_CONST_FN_OR_CONST - IS_EXTERN_FN
vlad20012
force-pushed
the
provide-more-ml-completion-element-features
branch
2 times, most recently
from
February 7, 2022 17:10
a0c17da
to
a1d7bb8
Compare
- IS_UNSAFE_CONTEXT - IS_ASYNC_CONTEXT - IS_CONST_CONTEXT
vlad20012
force-pushed
the
provide-more-ml-completion-element-features
branch
from
February 7, 2022 17:10
a1d7bb8
to
e2d9c81
Compare
bors r=ortem |
Build succeeded: |
Undin
added
internal
Pull requests about internal improvements/fixes that don't affect users directly
and removed
feature
labels
Feb 8, 2022
artemmukhin
added a commit
that referenced
this pull request
Apr 5, 2022
This enables the new features added in #8515 with 2021.3 builds. Originally, these new features were enabled only with 2022.1 builds to work with a previous ML ranking model. Now, since the model is updated to version 0.4.1, they can be used with any build.
artemmukhin
added a commit
that referenced
this pull request
Apr 8, 2022
This enables the new features added in #8515 with 2021.3 builds. Originally, these new features were enabled only with 2022.1 builds to work with a previous ML ranking model. Now, since the model is updated to version 0.4.1, they can be used with any build.
yopox
pushed a commit
to Kobzol/intellij-rust
that referenced
this pull request
Feb 27, 2023
This enables the new features added in intellij-rust#8515 with 2021.3 builds. Originally, these new features were enabled only with 2022.1 builds to work with a previous ML ranking model. Now, since the model is updated to version 0.4.1, they can be used with any build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6411
New element features:
New context features: