Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: move cursor after generated constructor in GenerateConstructor action #8674

Merged
merged 1 commit into from Mar 25, 2022
Merged

REF: move cursor after generated constructor in GenerateConstructor action #8674

merged 1 commit into from Mar 25, 2022

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Mar 20, 2022

Fixes: #8534

changelog: The Generate constructor action will now place the cursor after the generated constructor.

@Kobzol Kobzol added the fix Pull requests that fix some bug(s) label Mar 20, 2022
@Kobzol Kobzol added this to In Progress in To test via automation Mar 20, 2022
@dima74 dima74 self-assigned this Mar 21, 2022
@Kobzol Kobzol force-pushed the ref-generate-constructor-cursor branch from 70b5aea to f709c7c Compare March 25, 2022 10:02
@dima74
Copy link
Member

dima74 commented Mar 25, 2022

bors r+

bors bot added a commit that referenced this pull request Mar 25, 2022
@bors @Kobzol
Merge #8674
bb30f9d 
8674: REF: move cursor after generated constructor in GenerateConstructor action r=dima74 a=Kobzol

Fixes: #8534

changelog: The `Generate constructor` action will now place the cursor after the generated constructor.

Co-authored-by: Jakub Beránek <berykubik@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 25, 2022

Build failed:

@Kobzol
Copy link
Member Author

Kobzol commented Mar 25, 2022

bors retry

@bors
Copy link
Contributor

bors bot commented Mar 25, 2022

Build succeeded:

@bors bors bot merged commit 9e07d49 into intellij-rust:master Mar 25, 2022
To test automation moved this from In Progress to Test Mar 25, 2022
@github-actions github-actions bot added this to the v168 milestone Mar 25, 2022
@Kobzol Kobzol deleted the ref-generate-constructor-cursor branch March 25, 2022 14:28
@neonaot neonaot self-assigned this Mar 28, 2022
@neonaot neonaot moved this from Test to Done in To test Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dima74 dima74 dima74 left review comments

Assignees

@dima74 dima74

@neonaot neonaot

Labels
fix Pull requests that fix some bug(s)
Projects
To test
  
Done
Milestone
v168
Development

Successfully merging this pull request may close these issues.

Сonstructor generation puts cursor in weird place
3 participants
@Kobzol @dima74 @neonaot